Skip to content

Fix table borders being removed #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix table borders being removed #199

merged 2 commits into from
Apr 10, 2025

Conversation

@Tranquilite0
Copy link
Contributor

@Tranquilite0 Tranquilite0 commented Apr 4, 2025

I noticed that the table styles in my template word doc were having their borders removed when being converted to openxml. This fix changes things to only remove borders if the border html style was set.

@Tranquilite0
Fix table borders being removed
33abda1 
Fix table borders being removed even when the specified word table style has borders.
@onizet
Copy link
Owner

onizet commented Apr 10, 2025

Can you please paste some reproductible html snippets? Just for my understanding

@Tranquilite0
Copy link
Contributor Author

Tranquilite0 commented Apr 10, 2025

  1. Create a template Word Document and insert a table using the Table Grid 1 Light document style.
    • The exact table style used doesn't matter as long as it has borders.
  2. Convert the following HTML which uses the same table style and insert it into the document
<html>
    <head>
        <title></title>
    </head>
    <body>
        <p>This Table is inserted from HTML. It uses the same DOCX table style, but the border has been stripped.</p>
        <table class="GridTable1Light">
            <tr><td>One</td><td>Two</td></tr>
            <tr><td>Three</td><td>Four</td></tr>
        </table>
    </body>
</html>
  1. Note that the inserted table does not have any borders despite the style having borders specified:
    before
  2. After my fix it will have the same borders as the style:
    after

I feel like borders in Word Table styles should be respected.

The templates I have been using have a mix of table styles with and without borders, so postprocessing the document to add table borders back in is not trivial.

onizet
onizet reviewed Apr 10, 2025
View reviewed changes
@onizet
Copy link
Owner

onizet commented Apr 10, 2025

Good spot, it's a nice improvement. Thank you for the explanation, it's much easier for me to understand

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@onizet onizet merged commit d55a00d into onizet:dev Apr 10, 2025
1 of 3 checks passed
onizet added a commit that referenced this pull request Apr 15, 2025
@onizet
Fix the unit testing after new changes from #197 and #199
1fd6109
@onizet onizet mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onizet onizet onizet left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tranquilite0 @onizet