Skip to content

Fix table borders being removed #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix table borders being removed #199

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33abda1
Fix table borders being removed
Tranquilite0 Apr 4, 2025
316ae75
Revert inadvertent change.
Tranquilite0 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Html2OpenXml/Expressions/Table/TableExpression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ protected override void ComposeStyles (ParsingContext context)
}

var align = Converter.ToParagraphAlign(tableNode.GetAttribute("align"));
if (!align.HasValue)
align = Converter.ToParagraphAlign(styleAttributes["justify-self"]);
if (align.HasValue)
tableProperties.TableJustification = new() { Val = align.Value.ToTableRowAlignment() };

Expand Down Expand Up @@ -244,8 +242,9 @@ protected override void ComposeStyles (ParsingContext context)

tableProperties.TableBorders = tableBorders;
}
// is the border=0? If so, we remove the border regardless the style in use
else if (tableNode.Border == 0)
// is the border=0? If so, we remove the border regardless the style in use
// but only remove border if the html style border was set, otherwise leave the border style as-is.
else if (!styleBorder.IsEmpty && tableNode.Border == 0)
{
tableProperties.TableBorders = new TableBorders() {
TopBorder = new TopBorder { Val = BorderValues.None },
Expand Down
Loading