Skip to content

update test expectations for Highspot connector #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

Subash-Mohan
Copy link
Contributor

This pull request includes updates to the Highspot connector and its associated tests. The changes focus on logging unsupported formats, updating test expectations, and modifying test data.

Highspot Connector Updates:

  • Added a warning log for unsupported file formats in the _get_item_content method of the Highspot connector.

Test Updates:

  • Updated the test_highspot_connector_poll_source to provide a more detailed explanation for the expected failure due to Highspot's handling of document updates.
  • Modified the test data in test_highspot_data.json to reflect updated document identifiers and links.

How Has This Been Tested?

By running test class.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

@Subash-Mohan Subash-Mohan requested a review from a team as a code owner April 7, 2025 03:50
Copy link

vercel bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 3:50am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the Highspot connector by adding logging for unsupported file formats and updates the test suite to match the new behavior.

  • Added warning log in /backend/onyx/connectors/highspot/connector.py to capture unsupported file formats by logging the item ID and file extension.
  • Updated test data in /backend/tests/daily/connectors/highspot/test_highspot_data.json with new document identifiers and semantic fields.
  • Modified /backend/tests/daily/connectors/highspot/test_highspot_connector.py to adjust expectations and include an explicit xfail marker for the poll_source test.

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@rkuo-danswer rkuo-danswer enabled auto-merge April 7, 2025 05:12
@rkuo-danswer rkuo-danswer added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 157da24 Apr 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants