Skip to content

update test expectations for Highspot connector #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

update test expectations for Highspot connector #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/onyx/connectors/highspot/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ def _get_item_content(self, item_details: Dict[str, Any]) -> str:
return default_content

else:
logger.warning(
f"Item {item_id} has unsupported format: {file_extension}"
)
return default_content

except HighspotClientError as e:
Expand Down
8 changes: 5 additions & 3 deletions backend/tests/daily/connectors/highspot/test_highspot_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,11 @@ def test_highspot_connector_slim(
assert len(all_slim_doc_ids) > 0


@pytest.mark.xfail(
reason="failing, needs fix",
)
"""This test might fail because of how Highspot handles changes to the document's
"updated at" property. It is marked as expected to fail until we can confirm the behavior."""


@pytest.mark.xfail(reason="Highspot is not returning updated documents as expected.")
@patch(
"onyx.file_processing.extract_file_text.get_unstructured_api_key",
return_value=None,
Expand Down
6 changes: 3 additions & 3 deletions backend/tests/daily/connectors/highspot/test_highspot_data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"semantic_identifier": "Highspot in Action _ Salesforce Integration",
"link": "https://www.highspot.com/items/67cd8eb35d3ee0487de2e704",
"poll_source": {
"target_doc_id":"67ef9edcc3f40b2bf3d816a8",
"semantic_identifier":"A Brief Introduction To AI",
"link":"https://www.highspot.com/items/67ef9edcc3f40b2bf3d816a8"
"target_doc_id":"67efb452c3f40bcca2b48ca5",
"semantic_identifier":"Introduction to Intelligent Agents",
"link":"https://www.highspot.com/items/67efb452c3f40bcca2b48ca5"
}
}
Loading