Skip to content

feat(locales): add new translation keys and update Chinese locale#53

Merged
alwaysmavs merged 1 commit into
mainfrom
dev
Dec 6, 2025
Merged

feat(locales): add new translation keys and update Chinese locale#53
alwaysmavs merged 1 commit into
mainfrom
dev

Conversation

@alwaysmavs
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR adds three new locale keys (display-name3, description3, translated-epub-file-path) to English and Chinese locale files, updates package.oo.yaml metadata to reference the new display-name3 and description3 locale keys, and introduces a new "model" input to the translator task with locale placeholder descriptions.

Changes

Cohort / File(s) Change Summary
Locale key additions
oo-locales/en.json, oo-locales/zh-CN.json
Added three new translation keys: display-name3, description3, and translated-epub-file-path. Chinese locale file also includes updated commentary fields and revised translations for book translation workflows.
Package metadata updates
package.oo.yaml
Renamed project identifier from books-translator to books_translator; updated displayName to "%display-name3%" and description to "%description3%".
Task configuration
tasks/translator/task.oo.yaml
Added new "model" input under inputs_def with LLM model configuration (deepseek-chat, temperature: 0.5, top_p: 0.5, max_tokens: 4096); updated translated_file output description to "%translated-epub-file-path%".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify new locale keys are consistently added across both en.json and zh-CN.json files
  • Confirm package.oo.yaml locale key references (%display-name3%, %description3%) match entries in locale files
  • Validate the new model input configuration schema and default values in task.oo.yaml

Possibly related PRs

  • Dev #52: Modifies same localization keys and replaces translated_file output description with "%translated-epub-file-path%" placeholder
  • update #49: Updates localization and package metadata files with new locale keys and template placeholders
  • feat(tasks): update default LLM model #51: Updates task config default LLM model configuration and modifies package displayName/description with locale placeholders

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb51649 and 7ad5b9b.

📒 Files selected for processing (4)
  • oo-locales/en.json (1 hunks)
  • oo-locales/zh-CN.json (1 hunks)
  • package.oo.yaml (1 hunks)
  • tasks/translator/task.oo.yaml (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alwaysmavs alwaysmavs merged commit 41eb1e3 into main Dec 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant