-
-
Notifications
You must be signed in to change notification settings - Fork 292
Support integer type for min_value and max_value actions #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ue actions on integer type Co-authored-by: fabian-hiller <[email protected]>
… Schema converter Co-authored-by: fabian-hiller <[email protected]>
|
@copilot why did you modify the package.json? Can you undo it if it's not necessary? |
Co-authored-by: fabian-hiller <[email protected]>
Reverted the tsx dependency in commit 7e7ed25. It was added during initial testing but wasn't needed for the actual fix. |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the integer type when using minValue and maxValue actions in the valibot to-json-schema converter. Previously, these actions only supported the number type, which caused incorrect warnings when using integer schemas.
- Updated type checking logic for
min_valueandmax_valueactions to accept bothnumberandintegertypes - Added comprehensive test coverage for the new integer support
- Updated CHANGELOG to document the enhancement
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/to-json-schema/src/converters/convertAction/convertAction.ts | Added integer type support to min_value and max_value action validation |
| packages/to-json-schema/src/converters/convertAction/convertAction.test.ts | Added unit tests verifying correct behavior for minValue and maxValue actions with integer types |
| packages/to-json-schema/CHANGELOG.md | Documented the new integer type support for minValue and maxValue actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.