Skip to content

multimodal: Fixed the seaweed access#2022

Merged
vkb1 merged 1 commit intorelease-2026.0.0from
bugfix/svellais/seaweed_redirect
Mar 4, 2026
Merged

multimodal: Fixed the seaweed access#2022
vkb1 merged 1 commit intorelease-2026.0.0from
bugfix/svellais/seaweed_redirect

Conversation

@sathyendranv
Copy link
Copy Markdown
Contributor

@sathyendranv sathyendranv commented Mar 4, 2026

Description

multimodal: Fixed the seaweed access when docker network in different subnet

Fixes # (issue) ITEP-88063, ITEP-88200

Any Newly Introduced Dependencies

No

How Has This Been Tested?

Yes

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes.
  • I have not introduced any 3rd party components incompatible with APACHE-2.0.
  • I have not included any company confidential information, trade secret, password or security token.
  • I have performed a self-review of my code.

when docker network in different subnet

Signed-off-by: Vellaisamy, Sathyendran <sathyendran.vellaisamy@intel.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates multimodal’s SeaweedFS access path and proxy bypass configuration so image browsing works reliably when the Docker network uses a different subnet.

Changes:

  • Update the user guide to use the nginx-proxied image-store URL for browsing stored images.
  • Broaden SeaweedFS containers’ NO_PROXY/no_proxy CIDR from 172.18.0.0/16 to 172.16.0.0/12 in docker-compose.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
manufacturing-ai-suite/industrial-edge-insights-multimodal/docs/user-guide/how-to-guides/how-to-access-s3-stored-images.md Aligns “navigate to filer” instructions with the nginx /image-store access path.
manufacturing-ai-suite/industrial-edge-insights-multimodal/docker-compose.yml Expands SeaweedFS NO_PROXY/no_proxy CIDR to cover more Docker subnet allocations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +471 to +472
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

Comment on lines +495 to +496
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Suggested change
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,${DOCKER_NO_PROXY_CIDR:-172.16.0.0/12},${no_proxy}
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,${DOCKER_NO_PROXY_CIDR:-172.16.0.0/12},${no_proxy}

Copilot uses AI. Check for mistakes.
Comment on lines +434 to +435
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

Comment on lines +451 to +452
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

@vkb1 vkb1 merged commit 959ad1a into release-2026.0.0 Mar 4, 2026
41 checks passed
@vkb1 vkb1 deleted the bugfix/svellais/seaweed_redirect branch March 4, 2026 13:17
sathyendranv added a commit that referenced this pull request Mar 24, 2026
Updates multimodal’s SeaweedFS access path and proxy bypass configuration
so image browsing works reliably when the Docker network uses a different subnet.

Signed-off-by: Vellaisamy, Sathyendran <sathyendran.vellaisamy@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants