multimodal: Fixed the seaweed access#2022
Conversation
when docker network in different subnet Signed-off-by: Vellaisamy, Sathyendran <sathyendran.vellaisamy@intel.com>
There was a problem hiding this comment.
Pull request overview
Updates multimodal’s SeaweedFS access path and proxy bypass configuration so image browsing works reliably when the Docker network uses a different subnet.
Changes:
- Update the user guide to use the nginx-proxied
image-storeURL for browsing stored images. - Broaden SeaweedFS containers’
NO_PROXY/no_proxyCIDR from172.18.0.0/16to172.16.0.0/12indocker-compose.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| manufacturing-ai-suite/industrial-edge-insights-multimodal/docs/user-guide/how-to-guides/how-to-access-s3-stored-images.md | Aligns “navigate to filer” instructions with the nginx /image-store access path. |
| manufacturing-ai-suite/industrial-edge-insights-multimodal/docker-compose.yml | Expands SeaweedFS NO_PROXY/no_proxy CIDR to cover more Docker subnet allocations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 | ||
| - no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 |
There was a problem hiding this comment.
The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).
| - NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 | ||
| - no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 |
There was a problem hiding this comment.
The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).
| - NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 | |
| - no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 | |
| - NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,${DOCKER_NO_PROXY_CIDR:-172.16.0.0/12},${no_proxy} | |
| - no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,${DOCKER_NO_PROXY_CIDR:-172.16.0.0/12},${no_proxy} |
| - NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 | ||
| - no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 |
There was a problem hiding this comment.
The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).
| - NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 | ||
| - no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12 |
There was a problem hiding this comment.
The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).
Updates multimodal’s SeaweedFS access path and proxy bypass configuration so image browsing works reliably when the Docker network uses a different subnet. Signed-off-by: Vellaisamy, Sathyendran <sathyendran.vellaisamy@intel.com>
Description
multimodal: Fixed the seaweed access when docker network in different subnet
Fixes # (issue) ITEP-88063, ITEP-88200
Any Newly Introduced Dependencies
No
How Has This Been Tested?
Yes
Checklist: