Skip to content

multimodal: Fixed the seaweed access #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkb1 merged 1 commit into from
Mar 4, 2026
Merged

multimodal: Fixed the seaweed access #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions manufacturing-ai-suite/industrial-edge-insights-multimodal/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,8 @@ services:
volumes:
- seaweed_master_data:/data
environment:
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Comment thread
sathyendranv marked this conversation as resolved.
Comment on lines +434 to +435
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@vkb1 vkb1 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

command: master -ip=seaweedfs-master -ip.bind=0.0.0.0

seaweedfs-volume:
Expand All @@ -448,8 +448,8 @@ services:
volumes:
- seaweed_volume_data:/data
environment:
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Comment on lines +451 to +452
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@vkb1 vkb1 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

command: volume -mserver=seaweedfs-master:9333 -ip.bind=0.0.0.0 -port=8080
depends_on:
- seaweedfs-master
Expand All @@ -468,8 +468,8 @@ services:
- seaweed_filer_data:/data
- "vol_temp_seaweed_filer:/tmp"
environment:
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Comment on lines +471 to +472
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@vkb1 vkb1 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

command: filer -master=seaweedfs-master:9333 -ip.bind=0.0.0.0
depends_on:
- seaweedfs-master
Expand All @@ -492,8 +492,8 @@ services:
networks:
- timeseries_network
environment:
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.18.0.0/16
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
Comment on lines +495 to +496
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NO_PROXY/no_proxy values here fully overwrite any existing ${no_proxy} passed from the host environment (unlike other services in this compose file). Consider appending ${no_proxy} so existing proxy bypass settings are preserved, and making the Docker CIDR portion configurable rather than hardcoding 172.16.0.0/12 (which is very broad and may unintentionally bypass proxies for non-Docker 172.16/12 networks).

Suggested change
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,172.16.0.0/12
- NO_PROXY=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,${DOCKER_NO_PROXY_CIDR:-172.16.0.0/12},${no_proxy}
- no_proxy=localhost,127.0.0.1,seaweedfs-master,seaweedfs-volume,seaweedfs-filer,seaweedfs-s3,${DOCKER_NO_PROXY_CIDR:-172.16.0.0/12},${no_proxy}

Copilot uses AI. Check for mistakes.
# Comma-separated list of default buckets to create
- DEFAULT_S3_BUCKETS=dlstreamer-pipeline-results
# S3 credentials from .env file
Expand Down
2 changes: 1 addition & 1 deletion ...ghts-multimodal/docs/user-guide/how-to-guides/how-to-access-s3-stored-images.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Follow these steps to correlate detection events in InfluxDB with stored images:
3. Navigate to the Filer interface:

```text
http://<host_ip>:8887/buckets/dlstreamer-pipeline-results/weld-defect-classification/
https://<host_ip>:3000/image-store/buckets/dlstreamer-pipeline-results/weld-defect-classification/
```

4. Locate and open the file matching the `img_handle` (e.g., `X7TINNVPNX.jpg`).
Expand Down