ITEP-89829 - Automate tests for scene retrack functionality

[sbelhaik]

📝 Description

Automate tests for scene retrack functionality
JIRA: ITEP-89829

✨ Type of Change

Select the type of change your PR introduces:

• 🐞 Bug fix – Non-breaking change which fixes an issue
• 🚀 New feature – Non-breaking change which adds functionality
• 🔨 Refactor – Non-breaking change which refactors the code base
• 💥 Breaking change – Changes that break existing functionality
• 📚 Documentation update
• 🔒 Security update
• 🧪 Tests
• 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

• ✅ Tested manually
• 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

• 🔍 PR title is clear and descriptive
• 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
• 💬 I have commented my code, especially in hard-to-understand areas
• 📄 I have made corresponding changes to the documentation
• ✅ I have added tests that prove my fix is effective or my feature works

[Copilot]

Pull request overview

Adds a new functional test suite to validate scene retrack behavior when linking a child scene (Demo) to a newly created parent scene, and wires it into the functional test Makefile target.

Changes:

• Add retrack-object functional test target to run the new retrack test module.
• Introduce tc_scene_retrack.py with multiple retrack scenarios (retrack on/off and toggle), validating regulated-topic propagation and object ID behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 12 comments.

File	Description
tests/Makefile.functional	Adds a retrack-object target that runs the new retrack functional test with the standard compose stack and controller auth secret.
tests/functional/tc_scene_retrack.py	New functional tests that create/link scenes, toggle retrack via REST, publish camera detections via MQTT, and assert parent/child regulated outputs and ID semantics.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

[saratpoluri]

Still reviewing

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.

Comments suppressed due to low confidence (1)

tests/functional/common_retrack.py:1

• publish_data() mutates the obj_data fixture in-place (timestamp, bounding box, category). If objData is not function-scoped (or is reused by other tests), this can leak state across tests and cause order-dependent failures. Consider copying the dict (e.g., deep copy) inside publish_data()/publish_timed() before mutating, or constructing a per-publish payload object.

#!/usr/bin/env python3

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

[saratpoluri]

@copilot address all comments

[Copilot]

@copilot address all comments

Addressed all open comments in 99cb43d:

• Removed duplicate SECRETSDIR restore in Makefile.functional
• Added assert verify['count'] > 0 in set_retrack() before indexing results
• Added assert scene_data.statusCode == 200 before using scene_data in the rate-limiting test
• Changed teardown to use h.set_external_rate() so the controller gets the DB notification before the scene is torn down
• Improved teardown_scenes() with error-level logging, res.errors surfacing, and per-operation exception handling

Comments addressed

[saratpoluri]

@copilot fix all review comments

[Copilot]

@copilot fix all review comments

Done in eed57c4 — removed the redundant propagation test (NEX-T10536) and rewrote the toggle test to start with retrack=True using continuous publishing, observe new UUIDs, then toggle to retrack=False and observe preserved IDs.