doc: create rules overview for SB and CBA rules - #761
Conversation
Conflicts: doc/release_notes.md
Conflicts: scripts/_helpers.py scripts/cba/solve_cba_network.py scripts/sb/plot_offshore_network.py
| @@ -233,11 +193,6 @@ def optimize_with_rolling_horizon( | |||
| retry_kwargs["solver_name"] = fallback_solver["name"] | |||
| retry_kwargs["solver_options"] = fallback_solver.get("options", {}) | |||
| status, condition = n.optimize(sns, **retry_kwargs) # type: ignore | |||
|
|
|||
There was a problem hiding this comment.
it is just about the docstring of this function def solve_network it seems to remove the description on Returns
There was a problem hiding this comment.
I don't see any diff with master (see master code here).
open-tyndp/scripts/cba/solve_cba_network.py
Lines 203 to 235 in f4e1207
Either way, the function does not return anything, so I don't think it's useful to document it in the docstring. Do you agree?
There was a problem hiding this comment.
@tgilon thanks for preparing the PR! I agree with your suggestion for the rule grouping. There is just one minor comment about a docstring where I think the description for the return values is getting lost (but maybe this is intentional). Good to go from my side!
Closes # (if applicable).
Changes proposed in this Pull Request
Extends #759 and follow-up of #754. This PR creates rules overview for all SB and CBA rules. This PR also suggests to disable root TOC entries in order to declutter the table of contents for the rules overview (contributed upstream in PyPSA#2216).
Preview of the changes: https://open-tyndp--761.org.readthedocs.build/en/761/sb_rules/
Tasks
Workflow
Open issues
Notes
Generative AI was used to assist with code generation and review. All content has been reviewed, verified, and is the responsibility of the author.
Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.rstfiles.doc/release_notes.rstis added.doc/index.rst.