Skip to content

refac: remove cba.methods config option - #805

Merged
tgilon merged 4 commits into
masterfrom
refac/remove-cba-methods-config
Jul 30, 2026
Merged

refac: remove cba.methods config option#805
tgilon merged 4 commits into
masterfrom
refac/remove-cba-methods-config

Conversation

@measrainsey

@measrainsey measrainsey commented Jul 24, 2026

Copy link
Copy Markdown
Member

Closes:

Changes proposed in this Pull Request

PR to remove the cba.methods config option

Tasks

  • Remove cba.methods config option from config files and config validation files
  • Run pixi run generate-config to make sure all config schemas are up-to-date

Workflow

The cba.methods config option was originally created when we were implementing one CBA method (TOOT/PINT) at a time into Open-TYNDP. At the time, the cba.methods was used to apply just TOOT and/or just PINT to all projects. However, since then, we've implemented both methodologies into the workflow and have assigned each project-planning horizon a method based on the input data. Thus, cba.methods is no longer needed or used.

Checklist

Required:

  • Security scans show no high-severity bugs, critical vulnerabilities, or exposed secrets.
  • Changes are tested locally and behave as expected.
  • Code and workflow changes are documented.
  • A release note entry is added to doc/release_notes.md.
  • The description is human-written and any AI-generated content is marked.

If applicable:

  • Changes in configuration options are reflected in scripts/lib/validation.
  • Changes in configuration options are added to config/test/*.yaml.
  • Multiple climate years test passes locally (pixi run -e open-tyndp tyndp-cyears-test).
  • [ ] For new data sources or versions, these instructions have been followed.
  • [ ] Open-TYNDP SPDX license header is added to all touched files.
  • [ ] Module docstrings are added to new Python scripts.
  • [ ] New rules are documented in the appropriate doc/*.md files.
  • [ ] Major features are documented in doc/index.md.

@measrainsey measrainsey self-assigned this Jul 24, 2026
@measrainsey measrainsey added the CBA Cost Benefit Analysis label Jul 24, 2026
@measrainsey
measrainsey marked this pull request as ready for review July 24, 2026 09:33
@measrainsey measrainsey linked an issue Jul 24, 2026 that may be closed by this pull request
@tgilon
tgilon self-requested a review July 27, 2026 11:39

@tgilon tgilon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @measrainsey!

@tgilon
tgilon merged commit ad4d00b into master Jul 30, 2026
9 checks passed
@tgilon
tgilon deleted the refac/remove-cba-methods-config branch July 30, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CBA Cost Benefit Analysis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUB] Remove cba.methods config setting

2 participants