docs: add npm badges and update flagd-core version references#26
docs: add npm badges and update flagd-core version references#26jonathannorris merged 1 commit intomainfrom
Conversation
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation by adding npm package links and status badges, and bumps the referenced version of @openfeature/flagd-core to ^2.0.0. A review comment suggests clarifying the compatibility section in the README to avoid implying that versions prior to 2.0.0 lack Cloudflare Workers support, as this feature was originally introduced in version 1.3.0.
| ## Workers Compatibility | ||
|
|
||
| `@openfeature/flagd-core@1.3.0` and later support Cloudflare Workers and other V8 isolate runtimes without relying on dynamic code generation. This repo consumes the released package directly and uses `disableDynamicCodeGeneration: true` so targeting rules stay compatible with Workers runtime restrictions. The upstream work landed through [open-feature/js-sdk-contrib#1480](https://github.com/open-feature/js-sdk-contrib/issues/1480). | ||
| `@openfeature/flagd-core@^2.0.0` supports Cloudflare Workers and other V8 isolate runtimes without relying on dynamic code generation. This repo consumes the released package directly and uses `disableDynamicCodeGeneration: true` so targeting rules stay compatible with Workers runtime restrictions. The upstream work landed through [open-feature/js-sdk-contrib#1480](https://github.com/open-feature/js-sdk-contrib/issues/1480). |
There was a problem hiding this comment.
The update to @openfeature/flagd-core@^2.0.0 in this section might be misleading. The original text correctly identified that support for Cloudflare Workers began with version 1.3.0. By changing it to ^2.0.0, it implies that earlier versions (like 1.3.0 to 1.x) do not support it, which is not the case. It's better to maintain the historical compatibility information while noting the version currently used by this repository.
| `@openfeature/flagd-core@^2.0.0` supports Cloudflare Workers and other V8 isolate runtimes without relying on dynamic code generation. This repo consumes the released package directly and uses `disableDynamicCodeGeneration: true` so targeting rules stay compatible with Workers runtime restrictions. The upstream work landed through [open-feature/js-sdk-contrib#1480](https://github.com/open-feature/js-sdk-contrib/issues/1480). | |
| `@openfeature/flagd-core@1.3.0` and later (this repository uses `^2.0.0`) support Cloudflare Workers and other V8 isolate runtimes without relying on dynamic code generation. This repo consumes the released package directly and uses `disableDynamicCodeGeneration: true` so targeting rules stay compatible with Workers runtime restrictions. The upstream work landed through [open-feature/js-sdk-contrib#1480](https://github.com/open-feature/js-sdk-contrib/issues/1480). |
1 participant
Summary
flagd-coreversion references from@1.3.0+to@^2.0.0in both READMEs