refactor: Move course query from TakeCourseFragment to repository #10413
+38
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored TakeCourseFragment to use CoursesRepository for fetching course data. - Added getCourseById method to CoursesRepository to fetch a single course by its ID. The method returns a detached Realm object to ensure thread safety. - Replaced direct Realm database queries in TakeCourseFragment with calls to the new repository method. - Consolidated background operations in a single withContext(Dispatchers.IO) block for improved clarity and efficiency.
Okuro3499
previously requested changes
Jan 7, 2026
Collaborator
Okuro3499
left a comment
Okuro3499
left a comment
There was a problem hiding this comment.
java.lang.IllegalStateException: Can't commit a non-existing write transaction
at io.realm.internal.OsSharedRealm.nativeCommitTransaction(Native Method)
at io.realm.internal.OsSharedRealm.commitTransaction(OsSharedRealm.java:292)
at io.realm.BaseRealm.commitTransaction(BaseRealm.java:459)
at io.realm.Realm.commitTransaction(Realm.java:138)
at io.realm.Realm.executeTransaction(Realm.java:1634)
at org.ole.planet.myplanet.data.DatabaseService$executeTransactionAsync$2.invokeSuspend(DatabaseService.kt:60)
at org.ole.planet.myplanet.data.DatabaseService$executeTransactionAsync$2.invoke(Unknown Source:8)
at org.ole.planet.myplanet.data.DatabaseService$executeTransactionAsync$2.invoke(Unknown Source:4)
at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndspatched(Undispatched.kt:66)
at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturn(Undispatched.kt:43)
at kotlinx.coroutines.BuildersKt__Builders_commonKt.withContext(Builders.common.kt:165)
at kotlinx.coroutines.BuildersKt.withContext(Unknown Source:1)
at org.ole.planet.myplanet.data.DatabaseService.executeTransactionAsync(DatabaseService.kt:58)
at org.ole.planet.myplanet.repository.RealmRepository.executeTransaction(RealmRepository.kt:140)
at org.ole.planet.myplanet.repository.CoursesRepositoryImpl.joinCourse(CoursesRepositoryImpl.kt:193)
at org.ole.planet.myplanet.ui.courses.TakeCourseFragment$addRemoveCourse$1$isCurrentlyJoined$1.invokeSuspend(TakeCourseFragment.kt:343)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)
Refactored TakeCourseFragment to use CoursesRepository for fetching course data. - Added getCourseById method to CoursesRepository to fetch a single course by its ID. The method returns a detached Realm object to ensure thread safety. - Replaced direct Realm database queries in TakeCourseFragment with calls to the new repository method. - Consolidated background operations in a single withContext(Dispatchers.IO) block for improved clarity and efficiency. - Fixed a crash related to nested coroutine contexts causing an IllegalStateException during Realm transactions. Separated read and write operations to ensure proper transaction management.
Okuro3499
previously requested changes
Jan 8, 2026
Collaborator
Okuro3499
left a comment
Okuro3499
left a comment
There was a problem hiding this comment.
java.lang.IllegalStateException: Can't commit a non-existing write transaction
at io.realm.internal.OsSharedRealm.nativeCommitTransaction(Native Method)
at io.realm.internal.OsSharedRealm.commitTransaction(OsSharedRealm.java:292)
at io.realm.BaseRealm.commitTransaction(BaseRealm.java:459)
at io.realm.Realm.commitTransaction(Realm.java:138)
at io.realm.Realm.executeTransaction(Realm.java:1634)
at org.ole.planet.myplanet.data.DatabaseService$executeTransactionAsync$2.invokeSuspend(DatabaseService.kt:60)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)
Refactored TakeCourseFragment to use CoursesRepository for fetching course data. - Added getCourseById method to CoursesRepository to fetch a single course by its ID. The method returns a detached Realm object to ensure thread safety. - Replaced direct Realm database queries in TakeCourseFragment with calls to the new repository method. - Consolidated background operations in a single withContext(Dispatchers.IO) block for improved clarity and efficiency. - Fixed a crash related to nested coroutine contexts causing an IllegalStateException during Realm transactions. Separated read and write operations to ensure proper transaction management. - Fixed the root cause of the IllegalStateException by manually managing the Realm transaction lifecycle in DatabaseService.executeTransactionAsync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored TakeCourseFragment to use CoursesRepository for fetching course data.
https://jules.google.com/session/2078176696301205303