resources: smoother activity repository log coupling (fixes #10422) #10416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the logic for marking resources as added or removed from ResourcesRepositoryImpl into ActivityRepositoryImpl. - Added `markResourceAdded` and `markResourceRemoved` methods to the `ActivityRepository` interface and its implementation. - Injected `ActivityRepository` into `ResourcesRepositoryImpl`. - Replaced direct calls to `RealmRemovedLog` in `ResourcesRepositoryImpl` with calls to the new `ActivityRepository` methods. This change improves the separation of concerns by centralizing activity-related logging in a dedicated repository.
Moved the logic for marking resources as added or removed from ResourcesRepositoryImpl into ActivityRepositoryImpl. - Added `markResourceAdded` and `markResourceRemoved` methods to the `ActivityRepository` interface and its implementation. - Injected `ActivityRepository` into `ResourcesRepositoryImpl`. - Replaced direct calls to `RealmRemovedLog` in `ResourcesRepositoryImpl` with calls to the new `ActivityRepository` methods. - Fixed visibility of `RealmRemovedLog` properties and corrected the constructor in `ResourcesRepositoryImpl` to resolve build errors. This change improves the separation of concerns by centralizing activity-related logging in a dedicated repository.
Okuro3499
approved these changes
Jan 7, 2026
dogi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the logic for marking resources as added or removed from
ResourcesRepositoryImpl into ActivityRepositoryImpl.
markResourceAddedandmarkResourceRemovedmethods to theActivityRepositoryinterface and its implementation.ActivityRepositoryintoResourcesRepositoryImpl.RealmRemovedLoginResourcesRepositoryImplwith calls to the new
ActivityRepositorymethods.This change improves the separation of concerns by centralizing
activity-related logging in a dedicated repository.
https://jules.google.com/session/10309568436527492281