courses: smoother progress repository steps saving (fixes #10423) #10418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the logic for saving course progress from the `CourseStepFragment` to the `ProgressRepository`. This improves separation of concerns by centralizing database operations within the repository layer, making the fragment simpler and more focused on UI logic. The following changes were made: - Added `saveCourse-progress` to the `ProgressRepository` interface and `ProgressRepositoryImpl`. - Injected `ProgressRepository` into `CourseStepFragment` using Hilt. - Replaced the direct database call in `CourseStepFragment` with a call to the new repository method.
❌ 2 blocking issues (2 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
app/src/main/java/org/ole/planet/myplanet/repository/ProgressRepository.kt
Show resolved
Hide resolved
app/src/main/java/org/ole/planet/myplanet/repository/ProgressRepositoryImpl.kt
Show resolved
Hide resolved
Okuro3499
approved these changes
Jan 7, 2026
dogi
changed the title
app/src/main/java/org/ole/planet/myplanet/repository/ProgressRepository.kt
Show resolved
Hide resolved
app/src/main/java/org/ole/planet/myplanet/repository/ProgressRepositoryImpl.kt
Show resolved
Hide resolved
…sitory-1353736323483050373
| parentCode: String?, | ||
| courseId: String?, | ||
| stepNum: Int, | ||
| passed: Boolean? |
| parentCode: String?, | ||
| courseId: String?, | ||
| stepNum: Int, | ||
| passed: Boolean? |
dogi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the logic for saving course progress from the
CourseStepFragmentto theProgressRepository.This improves separation of concerns by centralizing database operations within the repository layer, making the fragment simpler and more focused on UI logic.
The following changes were made:
saveCourse-progressto theProgressRepositoryinterface andProgressRepositoryImpl.ProgressRepositoryintoCourseStepFragmentusing Hilt.CourseStepFragmentwith a call to the new repository method.https://jules.google.com/session/1353736323483050373