dashboard: smoother teams repository injecting (fixes #10424) #10419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Injects TeamsRepository into BaseDashboardFragment and overrides the handleClick method to fetch team details asynchronously using a coroutine. This change decouples the fragment from direct Realm access for team lookups, improving the architecture and removing the use of a blocking database call from the click handler.
Injects TeamsRepository into BellDashboardFragment and overrides the handleClick method to fetch team details asynchronously using a coroutine. This change decouples the fragment from direct Realm access for team lookups, improving the architecture and removing the use of a blocking database call from the click handler. It also adds the necessary Hilt bindings to make the TeamsRepository injectable.
Replaces a direct Realm query in the dashboard's team click handler with an asynchronous call to `TeamsRepository`. To avoid dependency conflicts in the `lite` build flavor, this change uses a Hilt `@EntryPoint` to safely access the `TeamsRepository` from the `BellDashboardFragment` without requiring a direct `@Inject` in the shared fragment. This decouples the UI from the data layer, improves the architecture, and resolves a multi-flavor build issue.
Okuro3499
approved these changes
Jan 7, 2026
dogi
changed the title
dogi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injects TeamsRepository into BaseDashboardFragment and overrides the handleClick method to fetch team details asynchronously using a coroutine.
This change decouples the fragment from direct Realm access for team lookups, improving the architecture and removing the use of a blocking database call from the click handler.
https://jules.google.com/session/18148738918996267520