smoother: toast message (fixes #5612) #5665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okuro3499
requested changes
Apr 14, 2025
Comment on lines
+647
to
+648
| <string name="removed_from_mylibrary">Resources Removed from myLibrary</string> | ||
| <string name="removed_from_mycourse">Course Removed from myCourse</string> |
There was a problem hiding this comment.
from the issue I understand what needed to be fixed was the string my library and my courses which had spaces between them compared to our naming convention which does not have spaces between
pavi38
requested changes
Apr 16, 2025
There was a problem hiding this comment.
hi @Avinash-Codes I am sure about this but should not the myCourses and MyLibrary remain same in all languages.
Okuro3499
requested changes
Apr 25, 2025
Comment on lines
+647
to
+648
| <string name="removed_from_mylibrary">Recursos eliminados de miLibrería</string> | ||
| <string name="removed_from_mycourse">Curso eliminado de misCursos</string> |
There was a problem hiding this comment.
mycourses and mylibrary should not be translated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5612