Skip to content

feat: new insights tab layout for list feature #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 14, 2023
Merged

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Sep 7, 2023

Description

This PR:

  • fixes the alignment of the CTA button in the list (all thanks to @brandonroberts and @jpmcb for noticing the miss alignment in feat: add ListCard component to design system #1687)
  • adds a type for list contributors and a refactor to replace dummy contributors with live data
  • adds fetch hooks for lists and contributors
  • refactors the code to break out pages and adds a loader
  • adds a redirect to insights tab when a user visits /hub route by default. (This is subject to change in the future)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #1668
Closes #1666

Mobile & Desktop Screenshots/Recordings

image

No list

image

With list

image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit fb377a3
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64ffdc417748230008385065
😎 Deploy Preview https://deploy-preview-1682--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit fb377a3
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64ffdc41c69e6e0008d23e67
😎 Deploy Preview https://deploy-preview-1682--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OgDev-01 OgDev-01 marked this pull request as ready for review September 11, 2023 12:55
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 👏🏼 (this is abunch of stub data from hacking on the API)

Screenshot 2023-09-11 at 8 31 13 AM

@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Sep 12, 2023
@OgDev-01 OgDev-01 mentioned this pull request Sep 12, 2023
19 tasks
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍕

@OgDev-01 OgDev-01 requested a review from jpmcb September 14, 2023 04:49
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice very nice!! 🥇

@OgDev-01 OgDev-01 merged commit 9269f1c into beta Sep 14, 2023
@OgDev-01 OgDev-01 deleted the 1666-new-insights-page branch September 14, 2023 19:56
open-sauced bot pushed a commit that referenced this pull request Sep 14, 2023
## [1.65.0-beta.6](v1.65.0-beta.5...v1.65.0-beta.6) (2023-09-14)

### 🍕 Features

* new insights tab layout for list feature  ([#1682](#1682)) ([9269f1c](9269f1c))

### 🐛 Bug Fixes

* new highlight responsiveness on mobile screens ([#1703](#1703)) ([bedb9d5](bedb9d5))
open-sauced bot pushed a commit that referenced this pull request Sep 20, 2023
## [1.65.0](v1.64.0...v1.65.0) (2023-09-20)

### 🍕 Features

* add `hacktoberfest` topic to dashboard filters ([#1688](#1688)) ([5c2beb0](5c2beb0))
* add `ListCard` component to design system ([#1687](#1687)) ([dd8df3e](dd8df3e))
* add feedback message to collab request form UI ([#1658](#1658)) ([3ccb7aa](3ccb7aa))
* new highlight creation popup (with highlight suggestions) ([#1646](#1646)) ([fe3d35d](fe3d35d))
* new insights tab layout for list feature  ([#1682](#1682)) ([9269f1c](9269f1c))
* Remove title input field from HighlightInputForm ([#1660](#1660)) ([abea60b](abea60b))

### 🐛 Bug Fixes

* handle `401` error on collaboration feature ([#1694](#1694)) ([756efdf](756efdf))
* improved padding for add repo dialog ([d4ef016](d4ef016))
* improved padding for add repo dialog ([#1720](#1720)) ([4d81cca](4d81cca))
* new highlight responsiveness on mobile screens ([#1703](#1703)) ([bedb9d5](bedb9d5))
* now add repo button appears on mobile view ([#1719](#1719)) ([22b0717](22b0717))
* opening someone's profile menu locks scrollbar and "shifts" header css ([#1704](#1704)) ([6282c27](6282c27))
* remove lists from insights hub nav ([#1711](#1711)) ([0d03f44](0d03f44))
* unlock Scroll when the Dropdown Menu is opened  ([#1712](#1712)) ([b74a4e8](b74a4e8))
* Update placeholder text for Highlight creation ([#1721](#1721)) ([3acd107](3acd107))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Page Tabs for Insights/Lists Hub List Creation Flow - New List Page Layout
3 participants