feat: create list feature #1698

OgDev-01 · 2023-09-12T03:41:06Z

Description

This pull request includes various features, fixes, and refactors to enhance the functionality and user experience of the Insights hub. It introduces the "hub list" feature, adds fetch hooks for lists and contributors, implements a filter chip component, and creates a contributor hub header component. Additionally, it includes several bug fixes, style updates, and code cleanups. Overall, these changes aim to improve the performance, layout, and navigation of the Insights hub.

Things to take note of

The range filter is not functional yet but will be added in my next PR
limit filter works
the other advanced filters will be coming up in follow up PRs

coming up next

What type of PR is this? (check all applicable)

Related Tickets & Documents

related to #1665 #1663

Mobile & Desktop Screenshots/Recordings

Components

Screen.Recording.2023-09-14.at.19.08.31.mov

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

…666-new-insights-page

netlify · 2023-09-12T03:41:10Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`c2eb8e2`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/650b8d0c61e17600088d2a9c
😎 Deploy Preview	https://deploy-preview-1698--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-09-12T03:41:10Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`c2eb8e2`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/650b8d0ceb2b0a0008cc8941
😎 Deploy Preview	https://deploy-preview-1698--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

OgDev-01 · 2023-09-12T04:48:33Z

Side note:

I pulled changes from #1682 to expedite implementation while it undergoes review.

…665-explore-contributors

…auced/insights into 1665-explore-contributors

…665-explore-contributors

OgDev-01 · 2023-09-19T19:10:42Z

When text is entered into the search bar, the "X" button causes the bar to "jump". Preferably, this would be smooth. For example, on Twitter when searching, the "X" button just appears within the search bar on the right without resizing the search bar itself

Nice catch 👍 . However, fixing the search close icon is out of the scope of this PR. I'll hide the search for now since search is not implemented from the API atm. Opened a ticket for that here #1717

jpmcb · 2023-09-19T20:25:09Z

Sounds good! The only thing from me then is the overlapping titles in Firefox!

I noticed that it's only happening with longer list names:

But not short ones:

OgDev-01 · 2023-09-20T10:45:33Z

Sounds good! The only thing from me then is the overlapping titles in Firefox!

I noticed that it's only happening with longer list names:

But not short ones:

This has been fixed in the most recent updates.

When the dropdown menu is opened, it causes the scroll bar to disappear which shifts the page over to the right (maybe related to #1696 ?)

this fix is still in progress for Select... hopefully it is merged soon radix-ui/primitives#2253. We can move forward with this until the fix is ready to imlement

OgDev-01 · 2023-09-20T13:08:03Z

Marking this as blocked till #1718 is merged. I need the multi-select component to implement some basic filters here

brandonroberts · 2023-09-20T19:35:11Z

@OgDev-01 Let's go ahead and get the page landed so we can reuse the contributors table in #1710. We can add filtering separately.

OgDev-01 · 2023-09-20T21:26:50Z

Aside adding filters, This is ready for review cc: @open-sauced/engineering

brandonroberts

Needs more work on mobile, but its functional

OgDev-01 · 2023-09-21T00:09:14Z

Will it be out of scope if I add a Delete flow for the list?

Screen.Recording.2023-09-21.at.01.07.47.mov

Similar to what was done with insights pages

jpmcb

Overall looks great! 👏🏼

I love the idea of a delete user flow. Typing DELETE works 👍🏼 I've also seen where you have to type the name of the resource your deleting to confirm it. I.e., if my list is named "My list", i'd have to type literally "My list" into the prompt to confirm the delete.

But I think if we need to get this PR in, we should look at that as a followup feature add.

## [1.66.0-beta.1](v1.65.0...v1.66.0-beta.1) (2023-09-21) ### 🍕 Features * add new`MultiSelect`component to design system ([#1718](#1718)) ([6405b43](6405b43)) * create list feature ([#1698](#1698)) ([7adfe94](7adfe94))

## [1.66.0](v1.65.0...v1.66.0) (2023-09-28) ### 🍕 Features * add `delete` functionality to list feature ([#1732](#1732)) ([8a3e1da](8a3e1da)) * add feature flag integration ([#1707](#1707)) ([2bfcf4c](2bfcf4c)) * add new`MultiSelect`component to design system ([#1718](#1718)) ([6405b43](6405b43)) * add User Search ([#1678](#1678)) ([008bf88](008bf88)) * create list feature ([#1698](#1698)) ([7adfe94](7adfe94)) ### 🐛 Bug Fixes * adjust button positioning for Firefox compatibility ([#1730](#1730)) ([91389ba](91389ba)) * adjust style to prevent shift ([#1754](#1754)) ([9328ab8](9328ab8)) * allow not onboarded users to interact with `insights` page ([#1722](#1722)) ([b37ce4d](b37ce4d)) * Cherry-pick 🍒 Update X icon ([#1759](#1759)) ([0a43e6a](0a43e6a)) * fix search bar bug ([#1735](#1735)) ([d16e93f](d16e93f)) * fixed a typo in 30 days label ([#1755](#1755)) ([2293dc2](2293dc2)) * make date selector visible on highlight creation ([#1761](#1761)) ([7b4014c](7b4014c)) * update field mapping for contributor lists create ([#1745](#1745)) ([71b704a](71b704a))

OgDev-01 added 11 commits September 7, 2023 14:55

feat: hub list feature initial commit

14ced90

Merge branch 'beta' of https://github.com/open-sauced/insights into 1…

bd6633d

…666-new-insights-page

fix: list CTA button alignment

10de192

chore: add type for list contributors

f15717e

refactor: replace dummy contributors with live data

66e2797

feat: add fetch hooks for lists and contributors

669372f

refactor: breakout tabs and add loader

4c2d63a

fix: build error

9e3b074

refactor: switch from tabs to pages

1bf47b4

fix: link href location

3d5bacd

refactor: add proper redirect to insights from hub

fb377a3

OgDev-01 mentioned this pull request Sep 12, 2023

feat: new insights tab layout for list feature #1682

Merged

19 tasks

feat: add filter chip component to design system

97d90ed

OgDev-01 and others added 14 commits September 13, 2023 16:02

style: update date filter styles

d7b8a22

feat: create contributor hub header component

62b4c77

chore: update header component props

b9d76df

feat: add comtributors hub layout

61c3866

chore: initial commit for hub contributors table implementation

2b53581

Merge branch 'beta' of https://github.com/open-sauced/insights into 1…

43ece18

…665-explore-contributors

chore: add contributor list global type

0627cbb

feat: implement contributor selct

b950edb

chore: minor layout updates and cleeanup

d4afed9

Merge branch 'beta' into 1665-explore-contributors

ee6bc8a

chore: add pagination layers

4b47408

Merge branch '1665-explore-contributors' of https://github.com/open-s…

709e5ed

…auced/insights into 1665-explore-contributors

Merge branch 'beta' of https://github.com/open-sauced/insights into 1…

48475c7

…665-explore-contributors

Merge branch 'beta' into 1665-explore-contributors

8527dc1

brandonroberts added requested changes and removed needs review PRs that need review from core engineering team labels Sep 19, 2023

OgDev-01 mentioned this pull request Sep 19, 2023

Bug: search bar X icon cause the bar to jump #1717

Closed

OgDev-01 added 2 commits September 20, 2023 11:40

feat: add switch for isPublic

9e79f6f

feat: add mozilla firefox prefix plugin to tailwind

c0b815e

Merge branch 'beta' into 1665-explore-contributors

6858893

OgDev-01 removed the requested changes label Sep 20, 2023

OgDev-01 self-assigned this Sep 20, 2023

OgDev-01 requested a review from jpmcb September 20, 2023 13:03

OgDev-01 added the blocked label Sep 20, 2023

OgDev-01 added needs review PRs that need review from core engineering team and removed blocked labels Sep 20, 2023

OgDev-01 removed their assignment Sep 20, 2023

misc: remove console logs

671e337

brandonroberts approved these changes Sep 20, 2023

View reviewed changes

fix: mobile responsiveness

c2eb8e2

jpmcb approved these changes Sep 21, 2023

View reviewed changes

OgDev-01 mentioned this pull request Sep 21, 2023

feat: add Delete feature to list #1731

Closed

brandonroberts merged commit 7adfe94 into beta Sep 21, 2023

brandonroberts deleted the 1665-explore-contributors branch September 21, 2023 14:07

jpmcb mentioned this pull request Sep 25, 2023

Bug: list creation feature in beta seems to have degraded? #1743

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: create list feature #1698

feat: create list feature #1698

OgDev-01 commented Sep 12, 2023 •

edited

Loading

netlify bot commented Sep 12, 2023 •

edited

Loading

netlify bot commented Sep 12, 2023 •

edited

Loading

OgDev-01 commented Sep 12, 2023

OgDev-01 commented Sep 19, 2023

jpmcb commented Sep 19, 2023

OgDev-01 commented Sep 20, 2023

OgDev-01 commented Sep 20, 2023

brandonroberts commented Sep 20, 2023

OgDev-01 commented Sep 20, 2023

brandonroberts left a comment

OgDev-01 commented Sep 21, 2023

jpmcb left a comment

feat: create list feature #1698

feat: create list feature #1698

Conversation

OgDev-01 commented Sep 12, 2023 • edited Loading

Description

Things to take note of

coming up next

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Components

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Sep 12, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

netlify bot commented Sep 12, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

OgDev-01 commented Sep 12, 2023

OgDev-01 commented Sep 19, 2023

jpmcb commented Sep 19, 2023

OgDev-01 commented Sep 20, 2023

OgDev-01 commented Sep 20, 2023

brandonroberts commented Sep 20, 2023

OgDev-01 commented Sep 20, 2023

brandonroberts left a comment

Choose a reason for hiding this comment

OgDev-01 commented Sep 21, 2023

jpmcb left a comment

Choose a reason for hiding this comment

OgDev-01 commented Sep 12, 2023 •

edited

Loading

netlify bot commented Sep 12, 2023 •

edited

Loading

netlify bot commented Sep 12, 2023 •

edited

Loading