Skip to content

Doc/add Acknowledgments#385

Merged
L-M-Sherlock merged 2 commits intomainfrom
Doc/add-Acknowledgments
Jan 13, 2026
Merged

Doc/add Acknowledgments#385
L-M-Sherlock merged 2 commits intomainfrom
Doc/add-Acknowledgments

Conversation

@L-M-Sherlock
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @L-M-Sherlock, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enrich the project's documentation by introducing a dedicated acknowledgements section. This addition serves to formally recognize and appreciate the individuals who have significantly contributed their time, ideas, and effort to the project's development and success, thereby enhancing community engagement and transparency.

Highlights

  • Documentation Enhancement: A new "Acknowledgements" section has been added to the README.md file.
  • Contributor Recognition: The new section formally recognizes several key contributors, detailing their specific contributions to the project.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a welcome "Acknowledgements" section to the README.md file to credit key contributors. This is a positive addition to the project's documentation. My review includes one minor suggestion to correct a typo for improved clarity.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@L-M-Sherlock L-M-Sherlock merged commit d897116 into main Jan 13, 2026
4 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Doc/add-Acknowledgments branch January 13, 2026 07:52

- Jarrett Ye — core algorithm, training, benchmarking, and documentation.
- Damien Elmes — training API robustness, progress handling, and dependency upkeep.
- Luc Mcgrady — simulator features, per-card parameters, and scheduling enhancements.
Copy link
Member

@Luc-Mcgrady Luc-Mcgrady Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it but this kind of makes it look like per cards parameters are a thing outside of the simulator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK? The simulator module's scope is too large now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants