Skip to content

Doc/add Acknowledgments #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
L-M-Sherlock merged 2 commits into from
Jan 13, 2026
Merged

Doc/add Acknowledgments #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ac9b7
Doc/add Acknowledgments
L-M-Sherlock Jan 13, 2026
b584adb
Update README.md
L-M-Sherlock Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,13 @@ to `.git/hooks/pre-commit`, then `chmod +x .git/hooks/pre-commit`
Before this crate was made, `go-fsrs` and other libraries already existed, so the name `rs-fsrs` was chosen.

Then we wanted to port the torch version to Rust so that everyone could optimize on their own devices (tch-rs uses libtorch which is too heavy). Since the algorithm is called `fsrs`, we add an `-rs` on the end.

## Acknowledgements

Thank you to everyone who has contributed time, ideas, and care to this project. Special thanks to:

- Jarrett Ye — core algorithm, training, benchmarking, and documentation.
- Damien Elmes — training API robustness, progress handling, and dependency upkeep.
- Luc Mcgrady — simulator features, per-card parameters, and scheduling enhancements.
Copy link
Member

@Luc-Mcgrady Luc-Mcgrady Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it but this kind of makes it look like per cards parameters are a thing outside of the simulator.

Copy link
Member Author

@L-M-Sherlock L-M-Sherlock Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK? The simulator module's scope is too large now...

- Asuka Minato — CI/tooling, bindings, and documentation updates.
- Expertium — scheduler/simulator tuning and parameter naming refinements.