Restrict SetCapabilities after Start()#538
Draft
tigrannajaryan wants to merge 1 commit intoopen-telemetry:mainfrom
Draft
Restrict SetCapabilities after Start()#538tigrannajaryan wants to merge 1 commit intoopen-telemetry:mainfrom
tigrannajaryan wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Member
Author
|
FYI @owais |
Only certain capabilities can be changed after Start(), see spec change: open-telemetry/opamp-spec#306
tigrannajaryan
force-pushed
the
tigran/limited-capability-changes
branch
from
e02f709 to
69a7720
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 82.38% 82.31% -0.07%
==========================================
Files 28 28
Lines 2208 2211 +3
==========================================
+ Hits 1819 1820 +1
- Misses 264 265 +1
- Partials 125 126 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only certain capabilities can be changed after Start(), see spec change: open-telemetry/opamp-spec#306