Restrict capabilities that may change after the first message#306
Open
tigrannajaryan wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Restrict capabilities that may change after the first message#306tigrannajaryan wants to merge 2 commits intoopen-telemetry:mainfrom
tigrannajaryan wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Member
Author
|
@andykellr @jaronoff97 you probably remember the discussion we had in this thread: open-telemetry/opamp-go#366 (comment) The last message I posted there was that we will restrict what capabilities may be changed after starting. However, we haven't changed the spec to reflect that. This PR adds the limitation. Please take a look. |
We made this decision a while back but forgot to update the spec: open-telemetry/opamp-go#366 (comment)
tigrannajaryan
force-pushed
the
tigran/limited-capability-changes
branch
from
426ee8c to
01d9fcd
Compare
We made this decision a while back but forgot to update the spec: open-telemetry/opamp-go#366 (comment)
jaronoff97
approved these changes
Mar 26, 2026
Member
Author
|
@evan-bradley I would also like your opinion on this. Does Supervisor ever change the set of supported capabilities after it starts the OpAMP Agent? Can this restriction cause problems for the Supervisor? |
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Mar 26, 2026
Only certain capabilities can be changed after Start(), see spec change: open-telemetry/opamp-spec#306
Member
Author
|
Corresponding change in opamp-go: open-telemetry/opamp-go#538 |
tigrannajaryan
added a commit
to tigrannajaryan/opamp-go
that referenced
this pull request
Mar 26, 2026
Only certain capabilities can be changed after Start(), see spec change: open-telemetry/opamp-spec#306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made this decision a while back but forgot to update the spec: open-telemetry/opamp-go#366 (comment)