Skip to content

[chore][pkg/ottl] Add profile to the infer priorities #39612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[chore][pkg/ottl] Add profile to the infer priorities #39612

wants to merge 2 commits into from

Conversation

rockdaboot
Copy link
Contributor

Description

Without this, inferring doesn't work. Ran into this while working on adding profiles support for the tranformprocessor.

For example, this error will be fixed with this PR:

unable to parse OTTL statement "set(profile.attributes[\"test\"], \"pass\") where resource.attributes[\"test\"] == \"pass\"": error while parsing arguments for call to "set": invalid argument at position 0: context "profile" from path "profile.attributes[test]" is not valid, it must be replaced by one of: "resource"

@rockdaboot rockdaboot marked this pull request as ready for review April 24, 2025 10:10
@github-actions github-actions bot requested a review from kentquirk April 24, 2025 10:10
edmocosta
edmocosta reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@edmocosta edmocosta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the tests so it includes and validates the new profile context order? Thanks!

@rockdaboot
Copy link
Contributor Author

Could you please update the tests so it includes and validates the new profile context order? Thanks!

👍 added the tests

@rockdaboot rockdaboot mentioned this pull request Apr 24, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmocosta edmocosta edmocosta left review comments

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

At least 1 approving review is required to merge this pull request.

Assignees

@codeboten codeboten

Labels
pkg/ottl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockdaboot @edmocosta @codeboten