Skip to content

[chore][pkg/pdatatest] Fix Attribute.Transform() by using pprofile.PutAttribute() #41205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

[chore][pkg/pdatatest] Fix Attribute.Transform() by using pprofile.PutAttribute() #41205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
000e844
[pkg/pdatatest] Fix Attribute.Transform() by using pprofile.PutAttrib…
rockdaboot Jul 9, 2025
a483017
Merge branch 'main' into fix-pkg-pdatatest
rockdaboot Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions pkg/pdatatest/pprofiletest/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (p *Profile) Transform(dic pprofile.ProfilesDictionary, psp pprofile.ScopeP
pp.SetOriginalPayloadFormat(p.OriginalPayloadFormat)
pp.OriginalPayload().FromRaw(p.OriginalPayload)
for _, at := range p.Attributes {
pp.AttributeIndices().Append(at.Transform(dic))
at.Transform(dic, pp)
}
for _, au := range p.AttributeUnits {
au.Transform(dic)
Expand Down Expand Up @@ -218,13 +218,13 @@ func (sa *Sample) Transform(dic pprofile.ProfilesDictionary, pp pprofile.Profile
pl.SetFunctionIndex(l.Function.Transform(dic))
}
for _, at := range loc.Attributes {
ploc.AttributeIndices().Append(at.Transform(dic))
at.Transform(dic, ploc)
}
}
psa.SetLocationsLength(int32(pp.LocationIndices().Len()) - psa.LocationsStartIndex())
psa.Value().FromRaw(sa.Value)
for _, at := range sa.Attributes {
psa.AttributeIndices().Append(at.Transform(dic))
at.Transform(dic, psa)
}
//nolint:revive,staticcheck
if sa.Link != nil {
Expand Down Expand Up @@ -272,7 +272,7 @@ func (m *Mapping) Transform(dic pprofile.ProfilesDictionary) {
pm.SetFileOffset(m.FileOffset)
pm.SetFilenameStrindex(addString(dic, m.Filename))
for _, at := range m.Attributes {
pm.AttributeIndices().Append(at.Transform(dic))
at.Transform(dic, pm)
}
pm.SetHasFunctions(m.HasFunctions)
pm.SetHasFilenames(m.HasFileNames)
Expand All @@ -285,14 +285,20 @@ type Attribute struct {
Value any
}

func (a *Attribute) Transform(dic pprofile.ProfilesDictionary) int32 {
pa := dic.AttributeTable().AppendEmpty()
pa.SetKey(a.Key)
if pa.Value().FromRaw(a.Value) != nil {
type attributable interface {
AttributeIndices() pcommon.Int32Slice
}

func (a *Attribute) Transform(dic pprofile.ProfilesDictionary, record attributable) {
v := pcommon.NewValueEmpty()
if err := v.FromRaw(a.Value); err != nil {
panic(fmt.Sprintf("unsupported attribute value: {%s: %v (type %T)}",
a.Key, a.Value, a.Value))
}
return int32(dic.AttributeTable().Len() - 1)
if err := pprofile.PutAttribute(dic.AttributeTable(), record, a.Key, v); err != nil {
panic(fmt.Sprintf("failed to put attribute: {%s: %v (type %T)}: %v",
a.Key, a.Value, a.Value, err))
}
}

type AttributeUnit struct {
Expand Down