[chore] Pass runCtx into supervisor Health check test #43681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinkingpoint
requested review from
a team,
atoulme and
evan-bradley
as code owners
sinkingpoint
changed the title
|
Added a [chore] here - I don't think a 1 line test fix warrants a changelog |
songy23
approved these changes
Oct 21, 2025
|
@songy23 Any idea why the CLA check is pending? I have signed the CLA in the past, but it's been a while, and there's no link here if I need to re-sign |
|
I've no idea, maybe try push an empty commit? |
|
No luck :/ @atoulme ? |
|
FYI, CLA seems to be having problem in OTel everywhere https://cloud-native.slack.com/archives/CK8QVEXQB/p1761050105368339 |
dmitryax
approved these changes
Oct 21, 2025
sinkingpoint
force-pushed
the
cdouch/opamp-test
branch
from
8ccd761 to
8e2c594
Compare
Without a valid `runCtx`, anything that attempts to use the context segfaults. In open-telemetry/opentelemetry-collector#14058 I am using the context, so this test borks. This adds the runCtx to fix it. Signed-off-by: sinkingpoint <[email protected]>
sinkingpoint
force-pushed
the
cdouch/opamp-test
branch
from
8e2c594 to
0029d01
Compare
|
Looks like the CLA stuff got fixed, so this is passing now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without a valid
runCtx, anything that attempts to use the context segfaults. Inopen-telemetry/opentelemetry-collector#14058 I am using the context, so this test borks. This adds the runCtx to fix it.
Link to tracking issue
open-telemetry/opentelemetry-collector#14058
Testing
Documentation