-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[processor/k8sattributes] introduce new observability metric otelcol.k8s.pod.association #44718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[processor/k8sattributes] introduce new observability metric otelcol.k8s.pod.association #44718
Conversation
a96f868 to
1fc115d
Compare
1fc115d to
b8c5481
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I would be fine with adding the new metric following the suggested dots approach. However I think we should not close #44587 until we fixed the components' internal metrics according to open-telemetry/opentelemetry-collector#12909. WDYT? |
|
We briefly discussed this specific case during the Collector Stability SIG. We can wait to have open-telemetry/opentelemetry-collector#14273 merged and then we can try to migrate the internal metrics from |
|
open-telemetry/opentelemetry-collector/pull/14273 is on the merge queue :) |
ChrsMark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition LGTM (needs rebase).
But let's also ensure we do the rename (_ to using .) as part of the related issue: #44718 (comment)
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
d9ed007 to
794725b
Compare
Description
Introduction of new observability metric:
otelcol.k8s.pod.associationwith
status,otelcol.signalandpod_identifierattributesLink to tracking issue
Related to #44587