[exporter/kafka] add support for partitioning kafka records#47243
Open
VihasMakwana wants to merge 6 commits intoopen-telemetry:mainfrom
Open
[exporter/kafka] add support for partitioning kafka records#47243VihasMakwana wants to merge 6 commits intoopen-telemetry:mainfrom
VihasMakwana wants to merge 6 commits intoopen-telemetry:mainfrom
Conversation
VihasMakwana
requested review from
a team,
MovieStoreGuy and
axw
as code owners
paulojmdias
reviewed
Mar 30, 2026
Co-authored-by: Paulo Dias <44772900+paulojmdias@users.noreply.github.com>
paulojmdias
reviewed
Mar 30, 2026
Member
paulojmdias
left a comment
paulojmdias
left a comment
There was a problem hiding this comment.
Thanks @VihasMakwana! Some notes for review
VihasMakwana
force-pushed
the
kafka-partition-extension
branch
from
8500606 to
10d179f
Compare
VihasMakwana
force-pushed
the
kafka-partition-extension
branch
from
10d179f to
6735ac6
Compare
paulojmdias
reviewed
Mar 31, 2026
| } | ||
|
|
||
| func (c *RecordPartitionerConfig) Validate() error { | ||
| fmt.Println(c.Type) |
Member
There was a problem hiding this comment.
Suggested change
| fmt.Println(c.Type) |
Maybe it was kept here by mistake
|
|
||
| func buildPartitionerOpt(cfg RecordPartitionerConfig, host component.Host) (kgo.Opt, error) { | ||
| switch cfg.Type { | ||
| case "", RecordPartitionerTypeSaramaCompatible: |
Member
There was a problem hiding this comment.
Suggested change
| case "", RecordPartitionerTypeSaramaCompatible: | |
| case RecordPartitionerTypeSaramaCompatible: |
We don't need to validate it empty right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for partitioning records based on known partitioners exposed by franz-go library.
A new config,
record_partitioneris exposed for this purpose. Moreover, users can also implement their own partitioning logic by implementing a new extension and implementing theRecordPartitionerExtensioninterface in the extension.Link to tracking issue
Fixes #46931
Testing
Added
Documentation
Added