-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[exporter/kafka] add support for partitioning kafka records #47243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChrsMark
merged 16 commits into
open-telemetry:main
from
VihasMakwana:kafka-partition-extension
Apr 9, 2026
+796
−5
Merged
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
15b9863
kafka: add known paritioners and extension to customize it
VihasMakwana 2f515b2
chlog fix
VihasMakwana bfad54e
Update .chloggen/kafka-partition-extension.yaml
VihasMakwana 9210ca7
lint and ci
VihasMakwana 6735ac6
unit test comments
VihasMakwana a622bc5
example of custom partitioner
VihasMakwana 9b570f4
Update exporter/kafkaexporter/config.go
VihasMakwana f4afc79
Update exporter/kafkaexporter/partitioner.go
VihasMakwana 05bb9ea
fix test
VihasMakwana f958f8e
review comments and update docs/tests
VihasMakwana 6f143a7
cleanup
VihasMakwana 301b40e
comment
VihasMakwana 241a3f1
unkeyed
VihasMakwana 4c478f9
lint
VihasMakwana 65f8bc4
simplify unmarshalling and add some test cases
VihasMakwana 0a20e4f
schema
VihasMakwana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog) | ||
| component: exporter/kafka | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add support for partitioning kafka records | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| issues: [46931] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | | ||
| Add support for RoundRobin and LeastBackup partitioning strategies, as well as custom partitioners | ||
| provided by RecordPartitionerExtension implementations. Users can implement their own partitioning logic | ||
| and plug it into the kafka exporter via the RecordPartitionerExtension interface. | ||
|
|
||
|
|
||
| # If your change doesn't affect end users or the exported elements of any package, | ||
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package kafkaexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/kafkaexporter" | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/twmb/franz-go/pkg/kgo" | ||
| "go.opentelemetry.io/collector/component" | ||
|
|
||
| "github.com/open-telemetry/opentelemetry-collector-contrib/internal/kafka" | ||
| ) | ||
|
|
||
| const ( | ||
| // RecordPartitionerTypeSaramaCompatible is the default partitioner. It uses a sticky | ||
| // key partitioner with Sarama-compatible FNV-1a hashing when a record key is set, | ||
| // and a random sticky partition when no key is set. | ||
| RecordPartitionerTypeSaramaCompatible = "sarama_compatible" | ||
|
|
||
| // RecordPartitionerTypeRoundRobin distributes records evenly across all available | ||
| // partitions in a round-robin fashion, regardless of the record key. | ||
| RecordPartitionerTypeRoundRobin = "round_robin" | ||
|
|
||
| // RecordPartitionerTypeLeastBackup routes each record to the partition with the fewest | ||
| // buffered records, which can reduce produce latency under uneven load. | ||
| RecordPartitionerTypeLeastBackup = "least_backup" | ||
|
|
||
| // RecordPartitionerTypeExtension delegates partitioning to a user-provided extension | ||
| // that implements RecordPartitionerExtension. | ||
| RecordPartitionerTypeExtension = "custom" | ||
VihasMakwana marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ) | ||
|
|
||
| // RecordPartitionerExtension is implemented by extensions that supply a custom Kafka record | ||
| // partitioner for use with the kafka exporter. | ||
| type RecordPartitionerExtension interface { | ||
| component.Component | ||
|
|
||
| GetPartitioner() kgo.Partitioner | ||
| } | ||
|
|
||
| func buildPartitionerOpt(cfg RecordPartitionerConfig, host component.Host) (kgo.Opt, error) { | ||
| switch cfg.Type { | ||
| case "", RecordPartitionerTypeSaramaCompatible: | ||
VihasMakwana marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return kgo.RecordPartitioner(kafka.NewSaramaCompatPartitioner()), nil | ||
| case RecordPartitionerTypeRoundRobin: | ||
| return kgo.RecordPartitioner(kgo.RoundRobinPartitioner()), nil | ||
| case RecordPartitionerTypeLeastBackup: | ||
| return kgo.RecordPartitioner(kgo.LeastBackupPartitioner()), nil | ||
| case RecordPartitionerTypeExtension: | ||
| if cfg.Extension == nil { | ||
| return nil, errRecordPartitionerExtRequired | ||
| } | ||
| ext, ok := host.GetExtensions()[*cfg.Extension] | ||
| if !ok { | ||
| return nil, fmt.Errorf("partitioner extension %q not found", cfg.Extension) | ||
| } | ||
| partExt, ok := ext.(RecordPartitionerExtension) | ||
| if !ok { | ||
| return nil, fmt.Errorf("extension %q does not implement RecordPartitionerExtension", cfg.Extension) | ||
| } | ||
| return kgo.RecordPartitioner(partExt.GetPartitioner()), nil | ||
| default: | ||
| return nil, fmt.Errorf("unknown partitioner type %q", cfg.Type) | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.