Skip to content

Conversation

@iblancasa
Copy link
Contributor

Description

This PR implements serialized bytes based batching for traces.

Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

@iblancasa iblancasa requested review from a team, bogdandrutu and dmitryax as code owners February 27, 2025 18:48
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest concern about this is the required changes to pdata. I am trying to see if there is any other way to avoid that.

@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 95.08197% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.17%. Comparing base (b741c48) to head (a0b8572).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
pdata/ptrace/pb.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12519      +/-   ##
==========================================
+ Coverage   92.16%   92.17%   +0.01%     
==========================================
  Files         471      472       +1     
  Lines       25561    25635      +74     
==========================================
+ Hits        23558    23629      +71     
- Misses       1591     1595       +4     
+ Partials      412      411       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iblancasa
Copy link
Contributor Author

My biggest concern about this is the required changes to pdata. I am trying to see if there is any other way to avoid that.

Ok. Please let me know if I can help with this somehow. I will very likely start working on the PRs for the other signals as well and adapt whatever is needed if there is a change.

@bogdandrutu
Copy link
Member

Needs rebase after #12550 is merged, and please make sure all fixes are also applied to this PR.

Signed-off-by: Israel Blancas <[email protected]>
@iblancasa
Copy link
Contributor Author

@bogdandrutu can you take a look? I think we are ready to go

@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 13, 2025
@bogdandrutu bogdandrutu enabled auto-merge March 13, 2025 17:58
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 13, 2025
Merged via the queue into open-telemetry:main with commit 9204a06 Mar 13, 2025
73 of 74 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
#### Description

This PR implements serialized bytes based batching for metrics.

#### Link to tracking issue

#3262

Continuation of #12299 made by @sfc-gh-sili.

Related PRs:
- #12550
- #12519

Signed-off-by: Israel Blancas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants