-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Bytes based batching for traces #12519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bogdandrutu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My biggest concern about this is the required changes to pdata. I am trying to see if there is any other way to avoid that.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12519 +/- ##
==========================================
+ Coverage 92.16% 92.17% +0.01%
==========================================
Files 471 472 +1
Lines 25561 25635 +74
==========================================
+ Hits 23558 23629 +71
- Misses 1591 1595 +4
+ Partials 412 411 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ok. Please let me know if I can help with this somehow. I will very likely start working on the PRs for the other signals as well and adapt whatever is needed if there is a change. |
2258146 to
d3aa4bd
Compare
|
Needs rebase after #12550 is merged, and please make sure all fixes are also applied to this PR. |
Signed-off-by: Israel Blancas <[email protected]>
|
@bogdandrutu can you take a look? I think we are ready to go |
9204a06
#### Description This PR implements serialized bytes based batching for metrics. #### Link to tracking issue #3262 Continuation of #12299 made by @sfc-gh-sili. Related PRs: - #12550 - #12519 Signed-off-by: Israel Blancas <[email protected]>
Description
This PR implements serialized bytes based batching for traces.
Link to tracking issue
#3262
Continuation of #12299 made by @sfc-gh-sili.