[chore] move from DialContext to NewClient #13663

sivchari · 2025-08-19T02:35:24Z

Description

Use grpc.NewClient instead of grpc.DialContext

Link to tracking issue

Fixes #13632

Testing

Documentation

codecov · 2025-08-19T03:58:31Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.09%. Comparing base (82c3e02) to head (9c842ac).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
config/configgrpc/configgrpc.go	60.00%	1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13663      +/-   ##
==========================================
- Coverage   92.10%   92.09%   -0.02%     
==========================================
  Files         668      668              
  Lines       41377    41381       +4     
==========================================
- Hits        38112    38110       -2     
- Misses       2227     2231       +4     
- Partials     1038     1040       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

songy23

cc @evan-bradley

evan-bradley · 2025-08-19T13:46:50Z

I suspect the contrib test failures are due to the fact that NewClient doesn't initiate a connection unlike DialContext, we should be able to fix that somewhat easily.

@sivchari Can you confirm that this doesn't reintroduce #11537? If possible, a basic test would be nice.

sivchari · 2025-09-02T08:54:34Z

Sorry for late, I added the condition to check whether the connection is established correctly

dmathieu · 2025-09-02T12:20:14Z

Were you able to explicitly confirm that the issue in #11537 isn't reintroduced here?

github-actions · 2025-09-17T03:18:52Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

config/configgrpc/configgrpc_test.go

github-actions · 2025-10-10T03:23:06Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

dmathieu · 2025-10-28T08:23:08Z

I'm marking this as "ready to merge" based on the number of approvals.
My comment about removing the test for go-grpc behavior is not a blocker.

github-actions · 2025-11-12T03:31:29Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions · 2025-11-28T03:31:22Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

codspeed-hq · 2025-11-28T08:22:18Z

Merging this PR will not alter performance

⚠️

Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 59 untouched benchmarks
⏩ 20 skipped benchmarks¹

_{Comparing sivchari:pr-13632 (9c842ac) with main (82c3e02)}

20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-12-16T03:40:10Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

tank-500m · 2025-12-28T16:02:13Z

Hi
is this issue still in progress?

dmathieu · 2026-01-05T09:40:23Z

For this to be merged, the unit tests need to be fixed.

gimsesu · 2026-01-07T03:10:14Z

Hi @sivchari,

Thank you for working on this PR. We're looking forward to this change as it would benefit our project that uses the OpenTelemetry Collector.
I saw that the PR has multiple approvals and is marked as "ready-to-merge." As @dmathieu mentioned, it looks like the unit tests need to be fixed before merging.
Is there anything the community can help with to move this forward? Please let us know if there's any way we can assist.
Thanks again for your contribution!

Signed-off-by: sivchari <shibuuuu5@gmail.com>

@dmathieu

Per review feedback from @dmathieu, this test was testing go-grpc behavior rather than collector code. The fix in go-grpc has been confirmed, so this automated test is not necessary.

sivchari · 2026-01-07T05:43:35Z

Sorry for late response, I missed comments. I removed test, so I think it's ok to be merged.
Thanks.

otelbot · 2026-01-08T20:40:12Z

Thank you for your contribution @sivchari! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Cannot be done in CI due to a new internal module in core. See https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/20846134948/job/59890092343 Extra changes: - Add temporary replace statements for go.opentelemetry.io/collector/internal/componentalias - Update Coralogix exporter tests after open-telemetry/opentelemetry-collector#13663

#### Description Use grpc.NewClient instead of grpc.DialContext  #### Link to tracking issue Fixes open-telemetry#13632  #### Testing  #### Documentation  --------- Signed-off-by: sivchari <shibuuuu5@gmail.com>

sivchari requested a review from a team as a code owner August 19, 2025 02:35

sivchari requested a review from codeboten August 19, 2025 02:35

bogdandrutu approved these changes Aug 19, 2025

View reviewed changes

sivchari changed the title ~~move from DialContext to NewClient~~ [chore] move from DialContext to NewClient Aug 19, 2025

iblancasa approved these changes Aug 19, 2025

View reviewed changes

songy23 approved these changes Aug 19, 2025

View reviewed changes

jmacd approved these changes Aug 19, 2025

View reviewed changes

github-actions bot added the Stale label Sep 17, 2025

dmathieu reviewed Sep 17, 2025

View reviewed changes

config/configgrpc/configgrpc_test.go Outdated Show resolved Hide resolved

github-actions bot removed the Stale label Sep 18, 2025

github-actions bot added the Stale label Oct 10, 2025

github-actions bot removed the Stale label Oct 17, 2025

dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Oct 28, 2025

dmathieu approved these changes Oct 28, 2025

View reviewed changes

dmathieu linked an issue Oct 28, 2025 that may be closed by this pull request

[exporter/otlp] gRPC balancer default behavior #14090

Closed

github-actions bot added Stale and removed Stale labels Nov 12, 2025

github-actions bot added the Stale label Nov 28, 2025

github-actions bot removed the Stale label Nov 29, 2025

github-actions bot added the Stale label Dec 16, 2025

gimsesu mentioned this pull request Jan 6, 2026

[exporter/otlp] dns:/// scheme treated as passthrough since v0.141.0, breaking DNS-based load balancing #14372

Closed

sivchari requested review from andrzej-stencel, dmitryax, evan-bradley and mx-psi as code owners January 7, 2026 05:41

sivchari added 4 commits January 7, 2026 14:42

move from DialContext to NewClient

f46cad2

Signed-off-by: sivchari <shibuuuu5@gmail.com>

check whter connection is established correctly

3fab953

Signed-off-by: sivchari <shibuuuu5@gmail.com>

add test for open-telemetry#11537

c0c98a2

Signed-off-by: sivchari <shibuuuu5@gmail.com>

remove TestClientConnWithNOPROXY test

9c842ac

Per review feedback from @dmathieu, this test was testing go-grpc behavior rather than collector code. The fix in go-grpc has been confirmed, so this automated test is not necessary.

sivchari force-pushed the pr-13632 branch from d5898d6 to 9c842ac Compare January 7, 2026 05:42

dmathieu removed the Stale label Jan 7, 2026

andrzej-stencel approved these changes Jan 8, 2026

View reviewed changes

bogdandrutu approved these changes Jan 8, 2026

View reviewed changes

bogdandrutu added this pull request to the merge queue Jan 8, 2026

Merged via the queue into open-telemetry:main with commit b752ad3 Jan 8, 2026
90 of 95 checks passed

dmitryax mentioned this pull request Jan 11, 2026

[chore] Update otel core collector dependencies open-telemetry/opentelemetry-collector-contrib#45330

Merged

gimsesu mentioned this pull request Jan 23, 2026

Release v1.50.0/v0.144.0 #14450

Closed

8 tasks

[chore] move from DialContext to NewClient #13663

[chore] move from DialContext to NewClient #13663

Uh oh!

Conversation

sivchari commented Aug 19, 2025

Description

Link to tracking issue

Testing

Documentation

Uh oh!

codecov bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

songy23 left a comment

Choose a reason for hiding this comment

Uh oh!

evan-bradley commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sivchari commented Sep 2, 2025

Uh oh!

dmathieu commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 10, 2025

Uh oh!

dmathieu commented Oct 28, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

codspeed-hq bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Dec 16, 2025

Uh oh!

tank-500m commented Dec 28, 2025

Uh oh!

dmathieu commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gimsesu commented Jan 7, 2026

Uh oh!

sivchari commented Jan 7, 2026

Uh oh!

Uh oh!

otelbot bot commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov bot commented Aug 19, 2025 •

edited

Loading

evan-bradley commented Aug 19, 2025 •

edited

Loading

codspeed-hq bot commented Nov 28, 2025 •

edited

Loading

dmathieu commented Jan 5, 2026 •

edited

Loading