Skip to content

[chore] move from DialContext to NewClient #13663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bogdandrutu merged 4 commits into from
Jan 8, 2026
Merged

[chore] move from DialContext to NewClient #13663

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f46cad2
move from DialContext to NewClient
sivchari Aug 19, 2025
3fab953
check whter connection is established correctly
sivchari Sep 2, 2025
c0c98a2
add test for #11537
sivchari Sep 17, 2025
9c842ac
remove TestClientConnWithNOPROXY test
sivchari Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions config/configgrpc/configgrpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,16 @@ func (cc *ClientConfig) ToClientConn(
if err != nil {
return nil, err
}
//nolint:staticcheck // SA1019 see https://github.com/open-telemetry/opentelemetry-collector/pull/11575
return grpc.DialContext(ctx, cc.sanitizedEndpoint(), grpcOpts...)
conn, err := grpc.NewClient(cc.sanitizedEndpoint(), grpcOpts...)
if err != nil {
return nil, err
}

// Initiate connection to match the previous behavior of DialContext
// This ensures the connection is established eagerly rather than lazily
conn.Connect()

return conn, nil
}

func (cc *ClientConfig) addHeadersIfAbsent(ctx context.Context) context.Context {
Expand Down
Loading