-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add detailed failure attributes to exporter send_failed metrics #14247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
82b21b3 to
17eb1c3
Compare
Merging this PR will improve performance by 31.9%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | with_a_new_value |
60 ns | 46 ns | +30.43% |
| ⚡ | BenchmarkProfilesToProto |
1.7 µs | 1.3 µs | +31.9% |
| ⚡ | with_an_existing_value |
60 ns | 46 ns | +30.43% |
| ⚡ | with_a_duplicate_value |
60 ns | 46 ns | +30.43% |
| ⚡ | BenchmarkTraceSizeSpanCount |
60 ns | 46 ns | +30.43% |
| ⚡ | BenchmarkMetricsToProto2k |
91.3 µs | 72.6 µs | +25.79% |
| ⚡ | BenchmarkTracesMarshalJSON |
6 µs | 4.8 µs | +25.2% |
Comparing iblancasa:13956-2 (3d2cf44) with main (77ffe4a)
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14247 +/- ##
=======================================
Coverage 91.84% 91.85%
=======================================
Files 677 677
Lines 42699 42727 +28
=======================================
+ Hits 39219 39247 +28
+ Misses 2425 2424 -1
- Partials 1055 1056 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iblancasa I think this is a good direction, left a handful of suggestions
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
Sorry for the force-push but I got some issues with the CI after merging |
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, I thought I had hit send already
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for bearing with me @iblancasa!
|
The test failures look like issues due to this PR. |
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
@open-telemetry/collector-maintainers can we merge this? |
…lemetry-collector into 13956-2
|
@open-telemetry/collector-maintainers I have some approvals for this PR. Can we merge it? |
Description
error.typeanderror.permanentattributes in detailed mode tootelcol_exporter_send_failed_<signal>metricsSuggested here #13957 (comment)
Link to tracking issue
Fixes #13956