Skip to content

Conversation

@iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Dec 2, 2025

Description

  • Added error.type and error.permanent attributes in detailed mode to otelcol_exporter_send_failed_<signal> metrics

Suggested here #13957 (comment)

Link to tracking issue

Fixes #13956

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

Merging this PR will improve performance by 31.9%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 7 improved benchmarks
✅ 54 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
with_a_new_value 60 ns 46 ns +30.43%
BenchmarkProfilesToProto 1.7 µs 1.3 µs +31.9%
with_an_existing_value 60 ns 46 ns +30.43%
with_a_duplicate_value 60 ns 46 ns +30.43%
BenchmarkTraceSizeSpanCount 60 ns 46 ns +30.43%
BenchmarkMetricsToProto2k 91.3 µs 72.6 µs +25.79%
BenchmarkTracesMarshalJSON 6 µs 4.8 µs +25.2%

Comparing iblancasa:13956-2 (3d2cf44) with main (77ffe4a)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.85%. Comparing base (77ffe4a) to head (3d2cf44).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...orter/exporterhelper/internal/obs_report_sender.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14247   +/-   ##
=======================================
  Coverage   91.84%   91.85%           
=======================================
  Files         677      677           
  Lines       42699    42727   +28     
=======================================
+ Hits        39219    39247   +28     
+ Misses       2425     2424    -1     
- Partials     1055     1056    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iblancasa I think this is a good direction, left a handful of suggestions

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Copy link
Contributor Author

Sorry for the force-push but I got some issues with the CI after merging main into my branch and noticed some of them were related to the merge.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I thought I had hit send already

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested a review from axw December 16, 2025 16:02
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Copy link
Contributor

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bearing with me @iblancasa!

@dmathieu
Copy link
Member

dmathieu commented Jan 7, 2026

The test failures look like issues due to this PR.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-maintainers can we merge this?

@iblancasa
Copy link
Contributor Author

@open-telemetry/collector-maintainers I have some approvals for this PR. Can we merge it?

@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[exporter/exporterhelper] Add exporter retry-drop metrics

4 participants