-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add detailed failure attributes to exporter send_failed metrics #14247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iblancasa
wants to merge
42
commits into
open-telemetry:main
Choose a base branch
from
iblancasa:13956-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+828
−88
Open
Changes from 2 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
eb7f0bd
Add detailed failure attributes to exporter send_failed metrics
iblancasa ab77cad
Fix CI
iblancasa bff292f
Apply feedback from code review and failure.retries_exhausted
iblancasa ecbeb51
Merge branch 'main' into 13956-2
iblancasa 522f200
Add e2e test
iblancasa 30cff73
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa 6816b42
Merge branch '13956-2' of github.com:iblancasa/opentelemetry-collecto…
iblancasa 8d444c6
Fix gomod for tests
iblancasa 91c6a61
Improve e2e test
iblancasa 382674b
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa d754e99
Remove retries_exhausted attribute
iblancasa a9e9e3a
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa ea6db37
Apply changes requested in code review
iblancasa 7b9b44f
Apply changes requested to code review
iblancasa b9d74bc
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa d297bcf
Fix ci
iblancasa 7a398c3
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa 4276caf
Fix ci
iblancasa d92313b
Merge branch 'main' into 13956-2
iblancasa f798d84
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa c398d0b
Merge branch '13956-2' of github.com:iblancasa/opentelemetry-collecto…
iblancasa c5d5d65
Fix CI
iblancasa 44cf342
Fix CI
iblancasa dfec94a
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa 5d43dcf
Remove incorrect added metric
iblancasa 6bdba4b
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa d5dcc50
Merge branch '13956-2' of github.com:iblancasa/opentelemetry-collecto…
iblancasa fdf0327
Fix CI
iblancasa 0ab847a
Merge branch 'main' into 13956-2
iblancasa 573a436
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa 8d6ba7c
Fix CI
iblancasa 47d8471
Merge branch '13956-2' of github.com:iblancasa/opentelemetry-collecto…
iblancasa fc28464
Merge branch '13956-2' of github.com:iblancasa/opentelemetry-collecto…
iblancasa 5ca12f2
Fix CI
iblancasa 443210c
Merge branch 'main' into 13956-2
iblancasa f7eaa2f
Merge branches '13956-2' and '13956-2' of github.com:iblancasa/opente…
iblancasa eb404aa
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
iblancasa a6a3d4b
Merge branch 'main' into 13956-2
iblancasa bb2fb5b
Merge branch 'main' into 13956-2
iblancasa edd4139
Merge branch 'main' into 13956-2
iblancasa 3d2cf44
Merge branch 'main' into 13956-2
iblancasa 820ce0f
Merge branch 'main' into 13956-2
iblancasa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. receiver/otlp) | ||
| component: all | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Add detailed failure attributes to exporter send_failed metrics at detailed telemetry level. | ||
|
|
||
| # One or more tracking issues or pull requests related to the change | ||
| issues: [13956] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |- | ||
| The `otelcol_exporter_send_failed_{spans,metric_points,log_records}` metrics now include | ||
| failure attributes when telemetry level is Detailed: `error.type` (OpenTelemetry semantic convention | ||
| describing the error class) and `failure.permanent` (indicates if error is permanent). | ||
| The `error.type` attribute captures gRPC status codes (e.g., "Unavailable", "ResourceExhausted"), | ||
| HTTP status codes (e.g., "404", "503"), standard Go errors (e.g., "Canceled", "DeadlineExceeded"), | ||
| and collector-specific errors (e.g., "RetryExhausted", "Shutdown"). | ||
| This enables better alerting and debugging by providing standardized error classification. | ||
|
|
||
| # Optional: The change log or logs in which this entry should be included. | ||
| # e.g. '[user]' or '[user, api]' | ||
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [user] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
exporter/exporterhelper/internal/metadata/generated_telemetry.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
6 changes: 3 additions & 3 deletions
6
exporter/exporterhelper/internal/metadatatest/generated_telemetrytest.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.