[chore] service: refactor otelconftelemetry-related code #14308
+322
−140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor some code so we can reduce the dependency tree (in a followup).
Replace TestServiceTelemetryConsistentInstanceID in the service package with a functional test under internal/e2e. The new test verifies telemetry by running the collector and sending a request to the otlp receiver, and then checking the resulting internal telemetry is as expected. The purpose of this change is to test behaviour, rather than implementation, to simplify further refactoring.
Move service/telemetry/internal/migration to service/telemetry/otelconftelemetry/internal/migration, since it's only used by otelconftelemetry.
Link to tracking issue
Part of #13809
Testing
N/A
Documentation
N/A