Skip to content

Conversation

@EdgeN8v
Copy link
Contributor

@EdgeN8v EdgeN8v commented Dec 22, 2025

Description

This PR addresses the crash issue reported in #14307 where the collector fails to start on unsupported operating systems (e.g., AIX) due to RegisterProcessMetrics returning an error.

Instead of failing the service initialization, this change logs a warning and allows the collector to continue starting, ensuring that core functionality remains available even if process metrics cannot be collected.

Link to Issue

Fixes #14307

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@EdgeN8v EdgeN8v requested a review from a team as a code owner December 22, 2025 06:54
@EdgeN8v EdgeN8v requested a review from axw December 22, 2025 06:54
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 22, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.81%. Comparing base (0550b08) to head (b74324a).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
service/service.go 84.61% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (84.61%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14319      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.02%     
==========================================
  Files         677      677              
  Lines       42679    42690      +11     
==========================================
+ Hits        39192    39195       +3     
- Misses       2429     2434       +5     
- Partials     1058     1061       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 6, 2026

Merging this PR will improve performance by 31.69%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

#### 🎉 Hooray! `codspeed-go` just leveled up to 1.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

⚡ 3 improved benchmarks
✅ 58 untouched benchmarks
⏩ 20 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
BenchmarkLogsMarshalJSON 3.8 µs 3 µs +29.35%
BenchmarkMetricsMarshalJSON 5.2 µs 3.9 µs +31.69%
BenchmarkTracesMarshalJSON 6 µs 4.6 µs +28.28%

Comparing EdgeN8v:fix/14307-aix-crash (b74324a) with main (0550b08)

Open in CodSpeed

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@axw
Copy link
Contributor

axw commented Jan 6, 2026

@EdgeN8v please fix CI. It seems the code is not formatted properly - you should be able to fix that by running make fmt.

@EdgeN8v
Copy link
Contributor Author

EdgeN8v commented Jan 6, 2026

@axw Done. I've ran make fmt.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working to address this @EdgeN8v.

Since we have a while until the next release, I'd like to see if we can more robustly address this. If someone else would like to get this in and revisit it later, feel free to dismiss my review.

@dmathieu dmathieu self-requested a review January 7, 2026 12:22
@dmathieu
Copy link
Member

dmathieu commented Jan 7, 2026

Your latest changes removed the warning when the metrics are disabled. We do want that behavior.
Also, it seems to me than @evan-bradley's suggestion was to use build tags to have the allow list (as gopsutil does), not to keep the strings list.

@EdgeN8v EdgeN8v force-pushed the fix/14307-aix-crash branch from bb60049 to 1564d8f Compare January 13, 2026 14:21
@EdgeN8v EdgeN8v force-pushed the fix/14307-aix-crash branch from 81bf75a to 375318d Compare January 14, 2026 14:16
@EdgeN8v EdgeN8v force-pushed the fix/14307-aix-crash branch from 375318d to 24ba878 Compare January 14, 2026 14:32
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EdgeN8v!

@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 15, 2026
Allows mocking the registration function to verify error handling in New.
@dmathieu dmathieu removed the ready-to-merge Code review completed; ready to merge by maintainers label Jan 15, 2026
@EdgeN8v EdgeN8v force-pushed the fix/14307-aix-crash branch from 71adbd3 to 30d4877 Compare January 16, 2026 16:16
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you keep making changes to approved PRs, it will never be merged.

@EdgeN8v
Copy link
Contributor Author

EdgeN8v commented Jan 19, 2026

@dmathieu Apologies for the noise. I misunderstood and thought additional updates were still needed even after the PR was marked ready. I’ve reverted back to the approved state and won’t make further changes unless requested.

@dmathieu dmathieu added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 21, 2026
@mx-psi mx-psi added this pull request to the merge queue Jan 26, 2026
Merged via the queue into open-telemetry:main with commit e9ce4c9 Jan 26, 2026
79 of 80 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Jan 26, 2026

Thank you for your contribution @EdgeN8v! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal telemetry breaks compiled binaries on unsupported OSes

5 participants