-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: gracefully handle process metrics registration failure on unsupported OSes #14319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
f664852
fix: log warning instead of failing on unsupported OSes for #14307
EdgeN8v f6955c8
Add changelog
EdgeN8v 917dc50
fix: skip process metrics registration on AIX only
EdgeN8v 44d206f
style: go fmt
EdgeN8v ec71fb4
fix: move constant to global scope and fix changelog formatting
EdgeN8v 11dac2e
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v 9377655
Update .chloggen/fix-aix-crash.yaml
EdgeN8v 2dc9a25
Update .chloggen/fix-aix-crash.yaml
EdgeN8v 685edfd
refactor: use allowlist for process metrics OS support
EdgeN8v 8303cfa
refactor: use build tags for process metrics support
EdgeN8v 0f7ee83
fix: wrap error context for process metrics registration
EdgeN8v 0ece2b3
chore: add missing license headers
EdgeN8v 51d5b0a
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v 2f47f4a
style: apply go fmt fixes
EdgeN8v 9830093
Merge branch 'fix/14307-aix-crash' of https://github.com/EdgeN8v/open…
EdgeN8v 890b8a5
chore: add porto import comments
EdgeN8v 01df302
test: add unit test coverage for process metrics
EdgeN8v 7b129ae
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v 47a3a20
test: add unit test coverage for process metrics on unsupported OSes
EdgeN8v fb6f933
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v d7bc9fe
chore: generate chloggen components and update tests
EdgeN8v acff13b
Merge branch 'fix/14307-aix-crash' of https://github.com/EdgeN8v/open…
EdgeN8v 24ba878
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v e0c7d20
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v 9319b20
test: refactor registerProcessMetrics to var for testability
EdgeN8v 1bf5b56
revert: remove test refactoring based on review feedback
EdgeN8v 30d4877
test: add poison meter factory to fix codecov failure in New
EdgeN8v 8b9aeca
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v b1cca13
service: make process metrics registration failure test deterministic
EdgeN8v 9f7c331
Merge branch 'main' into fix/14307-aix-crash
EdgeN8v b74324a
service: restore ready-to-merge state
EdgeN8v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| change_type: bug_fix | ||
| component: pkg/service | ||
| note: "Fix panic in process metrics on unsupported OSes (e.g. AIX)" | ||
EdgeN8v marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| issues: [14307] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.