Fix process metrics registration when telemetry metrics level is none #14341
+34
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When service.telemetry.metrics.level is set to 'none', the collector should skip registering process metrics to avoid errors on platforms where gopsutil is not supported (such as AIX). This change conditionally registers process metrics only when the metrics level is not LevelNone, preventing the 'failed to register process metrics: not implemented yet' error on unsupported platforms. Fixes regression introduced in v0.136.0 where the check for metrics level was removed.
Author
|
Thanks in advance for taking a look at this PR. I’ll actively follow up on feedback and make any required changes promptly—happy to adjust the approach or implementation as needed. |
Similar to the resolution for pcommon.Value in previous changes, this update ensures consistent documentation across all pdata types by clarifying that calling functions on zero-initialized instances is invalid usage. Changes: - Updated template files (one_of_field.go, one_of_message_value.go) to generate improved comment wording - Updated pcommon/value.go comments manually - Updated all generated pdata files to use consistent wording: 'is invalid and will cause a panic' instead of 'will cause a panic' This makes it clearer that using zero-initialized instances is not just dangerous but explicitly invalid usage, improving API documentation clarity.
dmitryax
reviewed
Jan 4, 2026
| // SetBool replaces the bool value associated with this Value, | ||
| // it also changes the type to be ValueTypeBool. | ||
| // Calling this function on zero-initialized Value will cause a panic. | ||
| // Calling this function on zero-initialized Value is invalid and will cause a panic. |
Member
|
@Arunodoy18 do you have the PR that broke it? Also, I'm not sure it's expected to require disabling the metrics on OSes unsupported by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced in v0.136.0 where custom compiled binaries for AIX (and other unsupported OSes) fail to start even when
service.telemetry.metrics.level: noneis configured.Problem
Starting from v0.136.0, the OpenTelemetry Collector fails to start on platforms where gopsutil is not supported (such as AIX) with the following error:
Error: failed to register process metrics: not implemented yet
This occurs even when the service configuration explicitly sets: