Fix/duplicate component ids #14443
Open
Fix/duplicate component ids #14443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arunodoy18
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
Arunodoy18
force-pushed
the
fix/duplicate-component-ids
branch
2 times, most recently
from
6b4ed90 to
7f89d7c
Compare
Member
|
Same as all your other PRs. Please only include the commits relevant for your PR. |
Arunodoy18
force-pushed
the
fix/duplicate-component-ids
branch
from
7f89d7c to
5957191
Compare
Arunodoy18
force-pushed
the
fix/duplicate-component-ids
branch
from
5957191 to
17d24a9
Compare
Author
|
Hi @dmathieu — thanks for the review. I’ve cleaned up the branch and force-pushed. All unrelated changes have been removed. Please take another look 🙏 |
Member
|
If you look at the original issue, the requirement is to hide the fix behind a feature flag, as well as a warning. This does none. |
Add configurable connection pool to OTLP gRPC exporter to address throughput bottlenecks under high RTT and HTTP/2 stream limits. - Add connection_pool.max_connections config field (default: 1) - Implement round-robin load distribution across N connections - Preserve all existing retry, queue, and timeout behavior - Add comprehensive tests for pooling and validation Changes: - config.go: Add ConnectionPoolConfig struct with validation - otlp.go: Support multiple connections with round-robin selection - otlp_test.go: Add tests for pooling, round-robin, and validation Backward compatible: defaults to single connection (current behavior)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13912
Adds validation to reject configuration files with duplicate component IDs in extensions, receivers, and exporters lists.
Changes:
Added duplicate validation for pipeline receivers and exporters in
service/pipelines/config.goValidate()method toservice/extensions/Configto check for duplicate extensionsTesting:
All new tests pass