Enable Roslyn analysis - final#4744
Merged
Kielek merged 20 commits intoopen-telemetry:mainfrom Jan 12, 2026
Merged
Conversation
intentionally .ConfigureAwait(true) as required by xUnit
Kielek
force-pushed
the
analysis-others
branch
from
248026c to
78e570f
Compare
RassK
reviewed
Jan 12, 2026
test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/PluginManagerTests.cs
Outdated
Show resolved
Hide resolved
RassK
reviewed
Jan 12, 2026
test/OpenTelemetry.AutoInstrumentation.Tests/Configurations/PluginManagerTests.cs
Show resolved
Hide resolved
RassK
reviewed
Jan 12, 2026
test/OpenTelemetry.AutoInstrumentation.Bootstrapping.Tests/FactRequiringEnvVarAttribute.cs
Show resolved
Hide resolved
RassK
reviewed
Jan 12, 2026
RassK
reviewed
Jan 12, 2026
RassK
approved these changes
Jan 12, 2026
Contributor
RassK
left a comment
RassK
left a comment
There was a problem hiding this comment.
some nits to think of, in general ok.
Kielek
force-pushed
the
analysis-others
branch
from
c9b5cd3 to
f80b986
Compare
Kielek
force-pushed
the
analysis-others
branch
from
f80b986 to
886c0a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why & What
Enable Roslyn analysis (
<AnalysisLevel>latest-All</AnalysisLevel>) globallyThere is some production code improvement related to the CA1863 detected in tests code.
Tests
CI
Checklist
[ ]CHANGELOG.mdis updated.[ ] Documentation is updated.Newfeatures are covered by tests.