Skip to content

ec2 detector v2 #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ec2 detector v2 #6961

wants to merge 3 commits into from

Conversation

akats7
Copy link
Contributor

@akats7 akats7 commented Mar 19, 2025

PR for V2 of EC2 detector, due to deprecation of aws-sdk-go

@akats7 akats7 requested a review from a team as a code owner March 19, 2025 07:03
@github-actions github-actions bot requested a review from pyohannes March 19, 2025 07:07
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 82.08955% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.8%. Comparing base (7d7d23f) to head (5e6bbe9).

Files with missing lines Patch % Lines
detectors/aws/ec2/v2/ec2.go 81.2% 11 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6961   +/-   ##
=====================================
  Coverage   75.8%   75.8%           
=====================================
  Files        206     208    +2     
  Lines      19240   19307   +67     
=====================================
+ Hits       14594   14649   +55     
- Misses      4213    4224   +11     
- Partials     433     434    +1     
Files with missing lines Coverage Δ
detectors/aws/ec2/v2/version.go 100.0% <100.0%> (ø)
detectors/aws/ec2/v2/ec2.go 81.2% <81.2%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is its own go.mod (as it should be), we should add an entry in CODEOWNERS.


// Version is the current release version of the EC2 resource detector.
func Version() string {
return "1.35.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this unstable first (which makes the version 0.60.0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not release this until we want it stabilized. Having a v2 package at a major version of less than 2 is incongruent. The package can be referenced via a commit hash until we want it stabilized.

Copy link

linux-foundation-easycla bot commented Mar 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@akats7 akats7 force-pushed the ec2-detector-v2 branch from d6a2c38 to 6de2772 Compare April 7, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants