Skip to content

Migrate to semconv for otelecho #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Oloruntobi1
Copy link
Contributor

Addresses the otelecho side comment in this issue:

#6919

@Oloruntobi1 Oloruntobi1 requested a review from a team as a code owner March 24, 2025 19:52
@github-actions github-actions bot requested a review from scorpionknifes March 24, 2025 19:52
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 88.60606% with 94 lines in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (836e94b) to head (7bf0745).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...abstack/echo/otelecho/internal/semconv/httpconv.go 88.4% 35 Missing and 14 partials ⚠️
...labstack/echo/otelecho/internal/semconv/v1.20.0.go 88.8% 13 Missing and 7 partials ⚠️
...com/labstack/echo/otelecho/internal/semconv/env.go 91.1% 11 Missing and 2 partials ⚠️
...om/labstack/echo/otelecho/internal/semconv/util.go 82.8% 10 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6980     +/-   ##
=======================================
+ Coverage   75.8%   76.3%   +0.5%     
=======================================
  Files        207     211      +4     
  Lines      19494   20312    +818     
=======================================
+ Hits       14786   15510    +724     
- Misses      4273    4342     +69     
- Partials     435     460     +25     
Files with missing lines Coverage Δ
...entation/github.com/labstack/echo/otelecho/echo.go 100.0% <100.0%> (ø)
...om/labstack/echo/otelecho/internal/semconv/util.go 82.8% <82.8%> (ø)
...com/labstack/echo/otelecho/internal/semconv/env.go 91.1% <91.1%> (ø)
...labstack/echo/otelecho/internal/semconv/v1.20.0.go 88.8% <88.8%> (ø)
...abstack/echo/otelecho/internal/semconv/httpconv.go 88.4% <88.4%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu changed the title [FEAT] migrate to semconv for otelecho Migrate to semconv for otelecho Mar 25, 2025
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add a changelog entry.

@Oloruntobi1 Oloruntobi1 force-pushed the feat/update-otelecho-use-semconv branch from 549c0ae to 5e0309b Compare March 25, 2025 14:57
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog entry (and to resolve the conflict).

@Oloruntobi1 Oloruntobi1 force-pushed the feat/update-otelecho-use-semconv branch from 5e0309b to 6c67a23 Compare March 26, 2025 13:53
@Oloruntobi1 Oloruntobi1 requested a review from dmathieu March 26, 2025 13:56
@Oloruntobi1
Copy link
Contributor Author

This needs a changelog entry (and to resolve the conflict).

Thanks. Done

@Oloruntobi1 Oloruntobi1 requested a review from dmathieu March 26, 2025 16:20
@Oloruntobi1 Oloruntobi1 force-pushed the feat/update-otelecho-use-semconv branch 3 times, most recently from 725af38 to a946e03 Compare March 27, 2025 00:21
@github-actions github-actions bot requested a review from akats7 March 27, 2025 00:21
@Oloruntobi1 Oloruntobi1 force-pushed the feat/update-otelecho-use-semconv branch from a946e03 to 53fd5ec Compare March 27, 2025 00:40
@dmathieu
Copy link
Member

Please run the test suite locally to ensure the CI doesn't fail.

@Oloruntobi1 Oloruntobi1 force-pushed the feat/update-otelecho-use-semconv branch from 53fd5ec to 7bf0745 Compare March 28, 2025 08:43
@Oloruntobi1
Copy link
Contributor Author

Please run the test suite locally to ensure the CI doesn't fail.

Yeah just did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants