-
Notifications
You must be signed in to change notification settings - Fork 651
Migrate to semconv for otelecho #6980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate to semconv for otelecho #6980
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6980 +/- ##
=======================================
+ Coverage 75.8% 76.3% +0.5%
=======================================
Files 207 211 +4
Lines 19494 20312 +818
=======================================
+ Hits 14786 15510 +724
- Misses 4273 4342 +69
- Partials 435 460 +25
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to add a changelog entry.
instrumentation/github.com/labstack/echo/otelecho/test/echo_test.go
Outdated
Show resolved
Hide resolved
549c0ae
to
5e0309b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a changelog entry (and to resolve the conflict).
5e0309b
to
6c67a23
Compare
Thanks. Done |
725af38
to
a946e03
Compare
a946e03
to
53fd5ec
Compare
Please run the test suite locally to ensure the CI doesn't fail. |
…ion/github.com/labstack/echo/otelecho/test
53fd5ec
to
7bf0745
Compare
Yeah just did. |
Addresses the
otelecho
side comment in this issue:#6919