Suppress logging mechanism to support console instrumentations#6355
Draft
martinkuba wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
Suppress logging mechanism to support console instrumentations#6355martinkuba wants to merge 2 commits intoopen-telemetry:mainfrom
martinkuba wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (20.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6355 +/- ##
==========================================
- Coverage 95.68% 95.30% -0.38%
==========================================
Files 313 367 +54
Lines 9671 11639 +1968
Branches 2227 2678 +451
==========================================
+ Hits 9254 11093 +1839
- Misses 417 546 +129
🚀 New features to boost your workflow:
|
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
In the browser repo, we are introducing an instrumentation for capturing console logs. There is an issue with the diagnostics logger - capturing console logs triggers work by the SDK, which may generate console logs using the diagnostics logger, which creates more work by the SDK ... infinite loop.
The issue has been discussed here.
Short description of the changes
This PR introduces a similar mechanism to the existing suppressTracing function. If users wanted to use the console instrumentation, they would configure the diagnostics logger this way:
The console instrumentation would then check if logging is suprressed:
Type of change
Please delete options that are not relevant.
Checklist: