-
Notifications
You must be signed in to change notification settings - Fork 299
messaging: add messaging_latest_experimental opt-in value #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
messaging: add messaging_latest_experimental opt-in value #3173
Conversation
1896e09 to
69bbbf4
Compare
69bbbf4 to
0916667
Compare
| > * SHOULD introduce an environment variable `OTEL_SEMCONV_STABILITY_OPT_IN` | ||
| > in the existing major version as a comma-separated list of category-specific values | ||
| > (e.g., http, databases, messaging). The list of values includes: | ||
| > * `messaging` - emit the new, stable messaging conventions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be crystal clear here and say that this only emits stable conventions? Because it says "stop emitting the old, experimental. I kinda don't like "old" here because there might be "new" unstable conventions as well, and are those included or not? :D
Maybe we just say: emit only stable messaging conventions. and keep it short.
Could also be done as a follow up. I just wanted to bring here now for discussions. CC @open-telemetry/specs-semconv-maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda don't like "old" here because there might be "new" unstable conventions as well, and are those included or not? :D
Heh, good point! I'm happy to follow-up on it if we decide to go that route. 🙂
Maybe we just say: emit only stable messaging conventions. and keep it short.
I like that. Maybe that small change could be the resolution for #3200 🙂
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
Fixes #2928
Changes
Adds
messaging_latest_experimentalas a possible value toSEMCONV_STABILITY_OPT_INfor instrumentations that want to update to the latest semconv without breaking end-users while messaging semconv is still in-development.The updated spec is also written in a way that once the messaging spec becomes stable, there's an opt-in flag for enabling the latest in-development semconv (attributes for instance) without having it on by default.
Note: I think the name of the flag could be aligned to be
messaging/latest-experimentalto follow a similar format tomessaging/dup, but choose to align with the GenAI semconv for now wheregenai_latest_experimentalis already used.Merge requirement checklist
[chore]