-
Notifications
You must be signed in to change notification settings - Fork 299
messaging: add messaging_latest_experimental opt-in value #3173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: "enhancement" | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: "messaging" | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: "Add messaging_latest_experimental feature flag to enable experimental messaging conventions" | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [2928] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,12 +24,17 @@ The Semantic Conventions for [Azure Service Bus](https://learn.microsoft.com/azu | |
| > * `messaging` - emit the new, stable messaging conventions, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we be crystal clear here and say that this only emits stable conventions? Because it says "stop emitting the old, experimental. I kinda don't like "old" here because there might be "new" unstable conventions as well, and are those included or not? :D Maybe we just say: emit only stable messaging conventions. and keep it short. Could also be done as a follow up. I just wanted to bring here now for discussions. CC @open-telemetry/specs-semconv-maintainers
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Heh, good point! I'm happy to follow-up on it if we decide to go that route. 🙂
I like that. Maybe that small change could be the resolution for #3200 🙂 |
||
| > and stop emitting the old experimental messaging conventions | ||
| > that the instrumentation emitted previously. | ||
| > * `messaging_latest_experimental` - emit the latest in-development messaging conventions | ||
| > and stop emitting the old experimental conventions (v1.24.0 or prior). If stable | ||
| > messaging conventions are available, emit both stable and latest in-development conventions. | ||
| > * `messaging/dup` - emit both the old and the stable messaging conventions, | ||
| > allowing for a seamless transition. | ||
| > * The default behavior (in the absence of one of these values) is to continue | ||
| > emitting whatever version of the old experimental messaging conventions | ||
| > the instrumentation was emitting previously. | ||
| > * Note: `messaging/dup` has higher precedence than `messaging` in case both values are present | ||
| > * Notes: | ||
| > * `messaging/dup` has higher precedence than `messaging` in case both values are present | ||
| > * `messaging_latest_experimental` has higher precedence than both `messaging/dup` and `messaging` | ||
| > * SHOULD maintain (security patching at a minimum) the existing major version | ||
| > for at least six months after it starts emitting both sets of conventions. | ||
| > * SHOULD drop the environment variable in the next major version. | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.