-
Notifications
You must be signed in to change notification settings - Fork 299
[db/oracledb] Update db.namespace definition #3201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
CC @open-telemetry/semconv-db-approvers , Can this PR be triaged. Thanks. |
… into dbnamespcechanges
sharadraju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| distributed environment. Its value consists of one or more valid identifiers | ||
| (alphanumeric ASCII characters) separated by periods. | ||
|
|
||
| **[18] `oracle.db.instance.name`:** There can be multiple instances associated with a single database service. It indicates the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only specific to RAC? What value will it have for non-RAC instances?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is available for non-RAC database too but it will be defaulted to db_name value.
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
sharadraju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2147
Changes
Updated the
db.namespaceattribute definition to represent only the database’sunique identifier. Information previously bundled into
db.namespace—includingPDB name, instance name, and service name—has been moved to dedicated attributes:
oracle.db.pdb,oracle.db.instance.name, andoracle.db.service.Introduced a new
oracle.db.domainattribute to capture the database domain(DB_DOMAIN).
Issue 2147 recommended splitting
db.namespaceinto multiple attributes. Thedb.namespaceattribute represents the database’s unique identifier, as defined in the Oracle documentation for DB_UNIQUE_NAMEAdditional attributes have been introduced to capture other properties of the connection:
Notes:
These attributes are available only after a successful login. They are not included on spans for failed logins.
The connection string can be supplied in multiple formats, making it difficult to reliably extract attributes such as the service name:
- TNS alias – A name resolved using tnsnames.ora file.
- EZConnect – hostname:port/serviceName, among other variants.
The service name provided by the user may change after a successful connection. oracle.db.service reflects the final, effective service name. For example, when using Oracle Global Data Services (GDS), a user-supplied global service name such as
srv1.shpool.oradbcloudmay resolve toeast%srv1.shpool.oradbcloud.For global services,
oracle.db.nameidentifies the logical database name, whiledb.namespaceprovides the unique identity of the physical database.Please suggest If I have to split this PR for db.namespace and other oracle db specific attributes (oracle.db...)
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]