Clarify cicd.pipeline.task.run.id uniqueness#3589
Open
kamphaus wants to merge 2 commits intoopen-telemetry:mainfrom
Open
Clarify cicd.pipeline.task.run.id uniqueness#3589kamphaus wants to merge 2 commits intoopen-telemetry:mainfrom
kamphaus wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
adrielp
reviewed
Apr 17, 2026
adrielp
approved these changes
Apr 17, 2026
joaopgrassi
reviewed
Apr 20, 2026
Comment on lines
+79
to
+80
| For a given pipeline run and task the `cicd.pipeline.task.run.id` MUST be unique. | ||
| For different pipeline runs of the same pipeline the task run id MAY remain the same and thus MAY allow correlating the `cicd.pipeline.task.run.result` |
Member
There was a problem hiding this comment.
Suggested change
| For a given pipeline run and task the `cicd.pipeline.task.run.id` MUST be unique. | |
| For different pipeline runs of the same pipeline the task run id MAY remain the same and thus MAY allow correlating the `cicd.pipeline.task.run.result` | |
| For a given pipeline run and task, the `cicd.pipeline.task.run.id` MUST be unique. | |
| For different runs of the same pipeline, `cicd.pipeline.task.run.id` MAY remain the same and allow correlating with `cicd.pipeline.task.run.result` |
I got confused with the multiple "pipeline and pipeline runs" so I rephrased it a bit. Also, I'm not entirely sure about the "correlation" part. Do we really need to include that? I don't particularly get any helpful insight from it from the small text here. Consider either removing it or maybe adding more explanation on how it can be correlated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3566
Changes
Clarify that
cicd.pipeline.task.run.idmust be unique within a pipeline runand that this id may be used for correlating results of a task across several pipeline runs.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]