-
Notifications
You must be signed in to change notification settings - Fork 345
Clarify cicd.pipeline.task.run.id uniqueness #3589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: cicd | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Clarify that `cicd.pipeline.task.run.id` must be unique within a pipeline run. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [3566] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: This id may be used for correlating results of a task across several pipeline runs. |
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -75,6 +75,10 @@ groups: | |||||||||
| stability: development | ||||||||||
| brief: > | ||||||||||
| The unique identifier of a task run within a pipeline. | ||||||||||
| note: > | ||||||||||
| For a given pipeline run and task the `cicd.pipeline.task.run.id` MUST be unique. | ||||||||||
| For different pipeline runs of the same pipeline the task run id MAY remain the same and thus MAY allow correlating the `cicd.pipeline.task.run.result` | ||||||||||
|
Comment on lines
+79
to
+80
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I got confused with the multiple "pipeline and pipeline runs" so I rephrased it a bit. Also, I'm not entirely sure about the "correlation" part. Do we really need to include that? I don't particularly get any helpful insight from it from the small text here. Consider either removing it or maybe adding more explanation on how it can be correlated? |
||||||||||
| of tasks across pipeline runs. | ||||||||||
| examples: ["12097"] | ||||||||||
| - id: cicd.pipeline.task.run.url.full | ||||||||||
| type: string | ||||||||||
|
|
||||||||||
Uh oh!
There was an error while loading. Please reload this page.