-
Notifications
You must be signed in to change notification settings - Fork 44
Allow attributes to be identifying or descriptive. #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow attributes to be identifying or descriptive. #735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made 2 minor comments, otherwise LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=====================================
Coverage 76.7% 76.7%
=====================================
Files 65 65
Lines 5012 5030 +18
=====================================
+ Hits 3846 3860 +14
- Misses 1166 1170 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is the next phase of open-telemetry/semantic-conventions#2246.
What this does:
role
field to Attribute with optionsIdentifying
orDescriptive
role
changesWhat this does not do:
role
.Why role
Why do we call this
role
? I did some investigation into names and actually thought LLM captured some considerations well, here's (snipped) output: