Skip to content

WEB-475: The data on the dispersion of savings accounts appears overlaping…#3546

Open
EDSONZ-WASSWA wants to merge 1 commit intoopenMF:devfrom
EDSONZ-WASSWA:The-data-on-the-dispersion-of-savings-acco-unts-appears-overlappings
Open

WEB-475: The data on the dispersion of savings accounts appears overlaping…#3546
EDSONZ-WASSWA wants to merge 1 commit intoopenMF:devfrom
EDSONZ-WASSWA:The-data-on-the-dispersion-of-savings-acco-unts-appears-overlappings

Conversation

@EDSONZ-WASSWA
Copy link
Copy Markdown

@EDSONZ-WASSWA EDSONZ-WASSWA commented Apr 29, 2026

…pping

Description

-Removed gap,position, padding left from transfer-container

  • Removed flex-wrap: wrap from column containers to prevent horizontal bleeding.
  • Removed gap in transfer section
  • Enforced width: 100% on sections and grids to ensure a consistent vertical layout.
  • This ensures that even in constrained environments, the data follows the intended vertical "dispersion" without overlapping horizontally.

Related issues and discussion

#{Issue Number}
https://mifosforge.jira.com/issues?filter=-1&selectedIssue=WEB-475

Screenshots, if any

webApp

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Style
    • Optimized the visual layout of the account transfer details view by ensuring all sections and containers utilize the full available width. Removed excess spacing between transfer sections and simplified container positioning to reduce visual clutter and create a more cohesive, streamlined appearance when viewing account transfer information.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@EDSONZ-WASSWA has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 20 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d2bcc44a-664b-41a6-9acd-9c79c70c3712

📥 Commits

Reviewing files that changed from the base of the PR and between 2203178 and 23970b8.

📒 Files selected for processing (1)
  • src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The stylesheet for the view account transfer component is modified to enforce full width on the transfer container, sections, and info grid while removing previous layout spacing properties like gaps and positioning.

Changes

Cohort / File(s) Summary
Stylesheet Layout Adjustments
src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss
Forces full width (100%) on container elements and removes previous gap and positioning properties for layout restructuring.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • IOhacker
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title addresses the main issue (overlapping data in account transfer details) and matches the changes made to fix layout spacing issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 23 minutes and 20 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss`:
- Around line 9-13: The .status-indicator is absolutely positioned but its
ancestor .transfer-container is not positioned, so add a positioning context by
setting .transfer-container to position: relative (preserving its existing
display/flex rules) so the .status-indicator aligns correctly relative to the
transfer card; update the .transfer-container rule (the selector named
transfer-container) to include position: relative.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 79e7c825-4d8e-4c54-bbe8-85c8d6b157d2

📥 Commits

Reviewing files that changed from the base of the PR and between 37615bd and 2203178.

📒 Files selected for processing (1)
  • src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss

Comment on lines 9 to 13
.transfer-container {
display: flex;
flex-direction: column;
gap: 1.5rem;
position: relative;
padding-left: 20px;
width: 100%;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Restore positioning context for the status indicator

Line 16 makes .status-indicator absolutely positioned, but .transfer-container no longer defines a positioned ancestor. This can misalign the indicator bar relative to the transfer card.

Suggested fix
 .transfer-container {
   display: flex;
   flex-direction: column;
+  position: relative;
   width: 100%;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.transfer-container {
display: flex;
flex-direction: column;
gap: 1.5rem;
position: relative;
padding-left: 20px;
width: 100%;
}
.transfer-container {
display: flex;
flex-direction: column;
position: relative;
width: 100%;
}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@src/app/account-transfers/view-account-transfer/view-account-transfer.component.scss`
around lines 9 - 13, The .status-indicator is absolutely positioned but its
ancestor .transfer-container is not positioned, so add a positioning context by
setting .transfer-container to position: relative (preserving its existing
display/flex rules) so the .status-indicator aligns correctly relative to the
transfer card; update the .transfer-container rule (the selector named
transfer-container) to include position: relative.

@EDSONZ-WASSWA EDSONZ-WASSWA force-pushed the The-data-on-the-dispersion-of-savings-acco-unts-appears-overlappings branch from 2203178 to 23970b8 Compare April 29, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant